Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 1663863002: Add product mode: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Reworked the flags setting: Moving to single file for all flag defintions. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | tools/utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 7b36c5f7563714c8fe7c13dea7dcf2e1a4d47d01..ed354d2578df578f2987074726a26c16339381b9 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -2340,7 +2340,20 @@ class TestUtils {
// is an X in front of the arch. We don't allow both a cross compiled
// and a normal version to be present (except if you specifically pass
// in the build_directory).
- var mode = (configuration['mode'] == 'debug') ? 'Debug' : 'Release';
+ var mode;
+ switch (configuration['mode']) {
+ case 'debug':
+ mode = 'Debug';
+ break;
+ case 'release':
+ mode = 'Release';
+ break;
+ case 'product':
+ mode = 'Product';
+ break;
+ default:
+ throw 'Unrecognized mode configuration: ${configuration['mode']}';
+ }
var arch = configuration['arch'].toUpperCase();
var normal = '$mode$arch';
var cross = '${mode}X$arch';
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | tools/utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698