Add product mode:

runtime/vm/symbols.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/symbols.h"
 
 #include "vm/handles.h"
 #include "vm/handles_impl.h"
 #include "vm/hash_table.h"
 #include "vm/isolate.h"
@@ skipping 18 matching lines @@
 #undef DEFINE_SYMBOL_LITERAL
 
   "",  // matches kKwTableStart.
 
 #define DEFINE_KEYWORD_SYMBOL_INDEX(t, s, p, a)                                \
   s,
   DART_KEYWORD_LIST(DEFINE_KEYWORD_SYMBOL_INDEX)
 #undef DEFINE_KEYWORD_SYMBOL_INDEX
 };
 
-DEFINE_FLAG(bool, dump_symbol_stats, false, "Dump symbol table statistics");
+PRODUCT_FLAG(false, bool, dump_symbol_stats, false,
+             "Dump symbol table statistics");

[siva, 2016/02/03 20:33:51]

Do you anticipate the product value being different from the default value in
some cases?

I was wondering if it is possible to set the default values to be what we want
in a product build.

Maybe the service isolate related parameters could potentially have different
values.

Could we use macros like
#define kProductTrue true
#define kProductFalse false
#define kDefaultTrue true
#define kDefaultFalse false

PRODUCT_FLAG(kProductFalse, bool dump_symbol_stats, kDefaultFalse...
to make it more readable as to which bool refers to product vs default

 
 
 RawString* StringFrom(const uint8_t* data, intptr_t len, Heap::Space space) {
   return String::FromLatin1(data, len, space);
 }
 RawString* StringFrom(const uint16_t* data, intptr_t len, Heap::Space space) {
   return String::FromUTF16(data, len, space);
 }
 RawString* StringFrom(const int32_t* data, intptr_t len, Heap::Space space) {
   return String::FromUTF32(data, len, space);
@@ skipping 639 matching lines @@
 RawObject* Symbols::GetVMSymbol(intptr_t object_id) {
   ASSERT(IsVMSymbolId(object_id));
   intptr_t i = (object_id - kMaxPredefinedObjectIds);
   if ((i > kIllegal) && (i < Symbols::kMaxPredefinedId)) {
     return symbol_handles_[i]->raw();
   }
   return Object::null();
 }
 
 }  // namespace dart