Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: tools/testing/dart/test_options.dart

Issue 1663863002: Add product mode: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Reworked the flags setting: Moving to single file for all flag defintions. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 852e86d1a6950a45874a18ad0a927cc9056d9e9e..8e23169fea7e59c3f641d50db9ec1ab32b75252a 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -50,7 +50,7 @@ class TestOptionsParser {
'mode',
'Mode in which to run the tests',
['-m', '--mode'],
- ['all', 'debug', 'release'],
+ ['all', 'debug', 'release', 'product'],
'debug'),
new _TestOptionSpecification(
'compiler',
@@ -692,7 +692,7 @@ Note: currently only implemented for dart2js.''',
configuration['arch'] = 'ia32,x64,simarm,simarm64,simmips';
}
if (configuration['mode'] == 'all') {
- configuration['mode'] = 'debug,release';
+ configuration['mode'] = 'debug,release,product';
}
if (configuration['report_in_json']) {
@@ -808,7 +808,7 @@ Note: currently only implemented for dart2js.''',
new CompilerConfiguration(configuration).computeTimeoutMultiplier();
int runtimeMultiplier =
new RuntimeConfiguration(configuration).computeTimeoutMultiplier(
- isDebug: configuration['mode'] == 'debug',
+ mode: configuration['mode'],
isChecked: configuration['checked'],
arch: configuration['arch']);
configuration['timeout'] = 60 * compilerMulitiplier * runtimeMultiplier;
« no previous file with comments | « tools/testing/dart/runtime_configuration.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698