Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 1663863002: Add product mode: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Reworked the flags setting: Moving to single file for all flag defintions. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gyp/configurations_xcode.gypi ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 19fcdda982198a3b576f0d2326a25653d6898027..8596c6fe41015d05c3552da4acc153dfc4e9dd59 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -66,7 +66,7 @@ class RuntimeConfiguration {
RuntimeConfiguration._subclass();
int computeTimeoutMultiplier({
- bool isDebug: false,
+ String mode,
bool isChecked: false,
String arch}) {
return 1;
@@ -165,7 +165,7 @@ class DartVmRuntimeConfiguration extends RuntimeConfiguration {
: super._subclass();
int computeTimeoutMultiplier({
- bool isDebug: false,
+ String mode,
bool isChecked: false,
String arch}) {
int multiplier = 1;
@@ -182,7 +182,7 @@ class DartVmRuntimeConfiguration extends RuntimeConfiguration {
multiplier *= 4;
break;
}
- if (isDebug) {
+ if (mode == 'debug') {
multiplier *= 2;
}
return multiplier;
@@ -193,7 +193,7 @@ class DartVmRuntimeConfiguration extends RuntimeConfiguration {
/// program named Dump Render Tree, hence the name.
class DrtRuntimeConfiguration extends DartVmRuntimeConfiguration {
int computeTimeoutMultiplier({
- bool isDebug: false,
+ String mode,
bool isChecked: false,
String arch}) {
return 4 // Allow additional time for browser testing to run.
@@ -201,7 +201,7 @@ class DrtRuntimeConfiguration extends DartVmRuntimeConfiguration {
// JavaScript and Dart code. I'm not convinced the inherited timeout
// multiplier is relevant for JavaScript.
* super.computeTimeoutMultiplier(
- isDebug: isDebug, isChecked: isChecked);
+ mode: mode, isChecked: isChecked);
}
}
« no previous file with comments | « tools/gyp/configurations_xcode.gypi ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698