Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed)

Created:
4 years, 10 months ago by leviw_travelin_and_unemployed
Modified:
4 years, 10 months ago
Reviewers:
eae
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jbroman, jchaffraix+rendering, jfernandez, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, Manuel Rego, rwlbuis, Stephen Chennney, sof, slimming-paint-reviews_chromium.org, svillar, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force all LayoutUnit construction to be explicit This makes conversion clearer and avoids issues with code in v8 implicitly converting built-in types to LayoutUnits. No functional changes beyond tiny differences in conversions, most to avoid unnecessary conversions. BUG=581254 Committed: https://crrev.com/a53769e518876692df6df46cf7b64bae1d734397 Cr-Commit-Position: refs/heads/master@{#376127}

Patch Set 1 #

Patch Set 2 : Add additional conversions to ThemePainterDefault.cpp #

Patch Set 3 : Fix multicol #

Total comments: 3

Patch Set 4 : update intValueForLength #

Patch Set 5 : Fix one test result #

Patch Set 6 : Fix tests #

Patch Set 7 : Fix test again #

Patch Set 8 : add test expectation #

Patch Set 9 : Fix build #

Patch Set 10 : Also fix LayoutRectTest.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -112 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 4 5 6 7 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 1 2 8 chunks +20 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 10 chunks +23 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FileUploadControlPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 4 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/LayoutUnit.h View 1 2 2 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/LengthFunctions.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/LengthFunctions.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutPoint.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRect.h View 1 2 3 4 5 6 7 4 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutSize.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/TransformState.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660863002/20001
4 years, 10 months ago (2016-02-03 05:53:20 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/174295)
4 years, 10 months ago (2016-02-03 06:48:51 UTC) #4
leviw_travelin_and_unemployed
4 years, 10 months ago (2016-02-12 00:34:41 UTC) #7
eae
https://codereview.chromium.org/1660863002/diff/40001/third_party/WebKit/Source/core/dom/Document.cpp File third_party/WebKit/Source/core/dom/Document.cpp (right): https://codereview.chromium.org/1660863002/diff/40001/third_party/WebKit/Source/core/dom/Document.cpp#newcode2087 third_party/WebKit/Source/core/dom/Document.cpp:2087: marginTop = style->marginTop().isAuto() ? marginTop : intValueForLength(style->marginTop(), LayoutUnit(width)); How ...
4 years, 10 months ago (2016-02-12 01:14:59 UTC) #8
leviw_travelin_and_unemployed
On 2016/02/12 at 01:14:59, eae wrote: > https://codereview.chromium.org/1660863002/diff/40001/third_party/WebKit/Source/core/dom/Document.cpp > File third_party/WebKit/Source/core/dom/Document.cpp (right): > > https://codereview.chromium.org/1660863002/diff/40001/third_party/WebKit/Source/core/dom/Document.cpp#newcode2087 ...
4 years, 10 months ago (2016-02-12 02:02:59 UTC) #9
leviw_travelin_and_unemployed
PTAL
4 years, 10 months ago (2016-02-12 02:14:19 UTC) #10
eae
LGTM
4 years, 10 months ago (2016-02-12 19:33:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660863002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660863002/80001
4 years, 10 months ago (2016-02-12 19:40:48 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/173457)
4 years, 10 months ago (2016-02-12 21:01:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660863002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660863002/120001
4 years, 10 months ago (2016-02-16 21:19:14 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/180752)
4 years, 10 months ago (2016-02-16 22:57:33 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660863002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660863002/140001
4 years, 10 months ago (2016-02-18 05:49:42 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/23400) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-18 06:01:34 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660863002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660863002/180001
4 years, 10 months ago (2016-02-18 09:03:54 UTC) #28
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 10 months ago (2016-02-18 09:08:59 UTC) #29
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 09:10:19 UTC) #31
Message was sent while issue was closed. 
Patchset 10 (id:??) landed as
https://crrev.com/a53769e518876692df6df46cf7b64bae1d734397
Cr-Commit-Position: refs/heads/master@{#376127}

Powered by Google App Engine
This is Rietveld 408576698