third_party/WebKit/Source/platform/LengthFunctions.h - Issue 1660863002: Force all LayoutUnit construction to be explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LengthFunctions.h

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix LayoutRectTest.cpp Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/LengthFunctions.h

diff --git a/third_party/WebKit/Source/platform/LengthFunctions.h b/third_party/WebKit/Source/platform/LengthFunctions.h

index db7e505fa583cd9f29cca7195e21b24bd47ba9c9..68d1bf77fdc6b016e200036fba03d5a00708dc69 100644

--- a/third_party/WebKit/Source/platform/LengthFunctions.h

+++ b/third_party/WebKit/Source/platform/LengthFunctions.h

@@ -33,7 +33,7 @@ class LayoutUnit;

class Length;

class LengthSize;

-PLATFORM_EXPORT int intValueForLength(const Length&, LayoutUnit maximumValue);

+PLATFORM_EXPORT int intValueForLength(const Length&, int maximumValue);

PLATFORM_EXPORT float floatValueForLength(const Length&, float maximumValue);

PLATFORM_EXPORT LayoutUnit minimumValueForLength(const Length&, LayoutUnit maximumValue);

PLATFORM_EXPORT LayoutUnit roundedMinimumValueForLength(const Length&, LayoutUnit maximumValue);