third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp - Issue 1660863002: Force all LayoutUnit construction to be explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix LayoutRectTest.cpp Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp b/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp

index 9b1237e879bebc340e1966c46e019989d04161f9..f9a3dea83be83d0de7f9c553a4518b3ef7674932 100644

--- a/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp

@@ -79,7 +79,7 @@ LayoutUnit SnapToLinesLayouter::computeInitialPositionAdjustment(LayoutUnit& ste

// 6. Let line be cue's computed line.

// 7. Round line to an integer by adding 0.5 and then flooring it.

- LayoutUnit linePosition = floorf(m_cueBox.snapToLinesPosition() + 0.5f);

+ LayoutUnit linePosition(floorf(m_cueBox.snapToLinesPosition() + 0.5f));

WritingMode writingMode = m_cueBox.style()->writingMode();

// 8. Vertical Growing Left: Add one to line then negate it.