third_party/WebKit/Source/platform/LengthFunctions.cpp - Issue 1660863002: Force all LayoutUnit construction to be explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LengthFunctions.cpp

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix LayoutRectTest.cpp Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/LengthFunctions.cpp

diff --git a/third_party/WebKit/Source/platform/LengthFunctions.cpp b/third_party/WebKit/Source/platform/LengthFunctions.cpp

index 0a15e5171dc3df64b62c720f63cf4653db1e8681..8b4a68f0ced5e7da63cb9d207bdb9b31c1a35d65 100644

--- a/third_party/WebKit/Source/platform/LengthFunctions.cpp

+++ b/third_party/WebKit/Source/platform/LengthFunctions.cpp

@@ -28,9 +28,9 @@

namespace blink {

-int intValueForLength(const Length& length, LayoutUnit maximumValue)

+int intValueForLength(const Length& length, int maximumValue)

{

- return static_cast<int>(valueForLength(length, maximumValue));

+ return static_cast<int>(valueForLength(length, LayoutUnit(maximumValue)));

}

float floatValueForLength(const Length& length, float maximumValue)