third_party/WebKit/Source/core/html/HTMLSelectElement.cpp - Issue 1660863002: Force all LayoutUnit construction to be explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix LayoutRectTest.cpp Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

index cb2276bd0603e68a3d13dfbb0b2d1ba905d4d488..fec711eb6ea20d6377546c6fd7cf5ed63f9bfbb1 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

@@ -1919,14 +1919,14 @@ LayoutUnit HTMLSelectElement::clientPaddingLeft() const

{

if (layoutObject() && layoutObject()->isMenuList())

return toLayoutMenuList(layoutObject())->clientPaddingLeft();

- return 0;

+ return LayoutUnit();

}

LayoutUnit HTMLSelectElement::clientPaddingRight() const

{

if (layoutObject() && layoutObject()->isMenuList())

return toLayoutMenuList(layoutObject())->clientPaddingRight();

- return 0;

+ return LayoutUnit();

}

void HTMLSelectElement::popupDidHide()