third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp - Issue 1660863002: Force all LayoutUnit construction to be explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix LayoutRectTest.cpp Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp

diff --git a/third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp b/third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp

index 04ad8bb4131d9315bf360656ede48022a6c5c647..305810f40ba3e8ef38b86423fad3d5fd6798f9f8 100644

--- a/third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp

+++ b/third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp

@@ -18,7 +18,7 @@ TEST(LayoutRectTest, ToString)

LayoutRect rect(1, 2, 3, 4);

EXPECT_EQ(String("1.000000,2.000000 3.000000x4.000000"), rect.toString());

- LayoutRect granularRect(1.6f, 2.7f, 3.8f, 4.9f);

+ LayoutRect granularRect(LayoutUnit(1.6f), LayoutUnit(2.7f), LayoutUnit(3.8f), LayoutUnit(4.9f));

EXPECT_EQ(String("1.593750,2.687500 3.796875x4.890625"), granularRect.toString());

}

#endif