third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp - Issue 1660863002: Force all LayoutUnit construction to be explicit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/geometry/LayoutRectTest.cpp

Issue 1660863002: Force all LayoutUnit construction to be explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix LayoutRectTest.cpp Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "platform/geometry/LayoutRect.h"	5 #include "platform/geometry/LayoutRect.h"

6	6

7 #include "testing/gtest/include/gtest/gtest.h"	7 #include "testing/gtest/include/gtest/gtest.h"

8 #include "wtf/text/WTFString.h"	8 #include "wtf/text/WTFString.h"

9	9

10 namespace blink {	10 namespace blink {

11	11

12 #ifndef NDEBUG	12 #ifndef NDEBUG

13 TEST(LayoutRectTest, ToString)	13 TEST(LayoutRectTest, ToString)

14 {	14 {

15 LayoutRect emptyRect = LayoutRect();	15 LayoutRect emptyRect = LayoutRect();

16 EXPECT_EQ(String("0.000000,0.000000 0.000000x0.000000"), emptyRect.toString( ));	16 EXPECT_EQ(String("0.000000,0.000000 0.000000x0.000000"), emptyRect.toString( ));

17	17

18 LayoutRect rect(1, 2, 3, 4);	18 LayoutRect rect(1, 2, 3, 4);

19 EXPECT_EQ(String("1.000000,2.000000 3.000000x4.000000"), rect.toString());	19 EXPECT_EQ(String("1.000000,2.000000 3.000000x4.000000"), rect.toString());

20	20

21 LayoutRect granularRect(1.6f, 2.7f, 3.8f, 4.9f);	21 LayoutRect granularRect(LayoutUnit(1.6f), LayoutUnit(2.7f), LayoutUnit(3.8f) , LayoutUnit(4.9f));

22 EXPECT_EQ(String("1.593750,2.687500 3.796875x4.890625"), granularRect.toStri ng());	22 EXPECT_EQ(String("1.593750,2.687500 3.796875x4.890625"), granularRect.toStri ng());

23 }	23 }

24 #endif	24 #endif

25	25

26 } // namespace blink	26 } // namespace blink

OLD	NEW