Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin
This was usually already an origin, and is used for security-sensitive
purposes such as de-duplicating permission bubble requests (see also
https://codereview.chromium.org/1610753002), so renaming it to GetOrigin
to be explicit.
BUG=577313
Committed: https://crrev.com/fe4e96d4b85e691037fb64705010851830ec1cf9
Cr-Commit-Position: refs/heads/master@{#371795}
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637913002/1
4 years, 11 months ago
(2016-01-27 15:33:57 UTC)
#8
4 years, 11 months ago
(2016-01-27 16:14:51 UTC)
#9
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin This was usually already an origin, ...
4 years, 11 months ago
(2016-01-27 16:16:20 UTC)
#10
Message was sent while issue was closed.
Description was changed from
==========
Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin
This was usually already an origin, and is used for security-sensitive
purposes such as de-duplicating permission bubble requests (see also
https://codereview.chromium.org/1610753002), so renaming it to GetOrigin
to be explicit.
BUG=577313
==========
to
==========
Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin
This was usually already an origin, and is used for security-sensitive
purposes such as de-duplicating permission bubble requests (see also
https://codereview.chromium.org/1610753002), so renaming it to GetOrigin
to be explicit.
BUG=577313
Committed: https://crrev.com/fe4e96d4b85e691037fb64705010851830ec1cf9
Cr-Commit-Position: refs/heads/master@{#371795}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fe4e96d4b85e691037fb64705010851830ec1cf9 Cr-Commit-Position: refs/heads/master@{#371795}
4 years, 11 months ago
(2016-01-27 16:16:21 UTC)
#11
Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin
(Closed)
Created 4 years, 11 months ago by johnme
Modified 4 years, 11 months ago
Reviewers: felt, Nico
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0