Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin (Closed)

Created:
4 years, 11 months ago by johnme
Modified:
4 years, 11 months ago
Reviewers:
Nico, felt
CC:
chromium-reviews, asanka, msramek+watch_chromium.org, posciak+watch_chromium.org, tfarina, mcasas+watch_chromium.org, raymes+watch_chromium.org, feature-media-reviews_chromium.org, mlamouri+watch-permissions_chromium.org, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin This was usually already an origin, and is used for security-sensitive purposes such as de-duplicating permission bubble requests (see also https://codereview.chromium.org/1610753002), so renaming it to GetOrigin to be explicit. BUG=577313 Committed: https://crrev.com/fe4e96d4b85e691037fb64705010851830ec1cf9 Cr-Commit-Position: refs/heads/master@{#371795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -46 lines) Patch
M chrome/browser/chrome_quota_permission_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_permission_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_permission_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_permission_request.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_bubble_request_impl.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/permissions/permission_bubble_request_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_request.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_request.h View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
johnme
4 years, 11 months ago (2016-01-26 15:54:18 UTC) #2
felt
lgtm, nice cleanup.
4 years, 11 months ago (2016-01-27 06:17:35 UTC) #3
johnme
thakis@chromium.org: Please review changes in - chrome/browser/chrome_quota_permission_context.cc - chrome/browser/custom_handlers/ - chrome/browser/download/ - chrome/browser/media/ - chrome/browser/ui/ ...
4 years, 11 months ago (2016-01-27 11:45:07 UTC) #5
Nico
lgtm
4 years, 11 months ago (2016-01-27 15:32:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1637913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1637913002/1
4 years, 11 months ago (2016-01-27 15:33:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 16:14:51 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 16:16:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe4e96d4b85e691037fb64705010851830ec1cf9
Cr-Commit-Position: refs/heads/master@{#371795}

Powered by Google App Engine
This is Rietveld 408576698