chrome/browser/permissions/permission_bubble_request_impl.h - Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.h

Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/permissions/permission_bubble_request_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_bubble_request_impl.h

diff --git a/chrome/browser/permissions/permission_bubble_request_impl.h b/chrome/browser/permissions/permission_bubble_request_impl.h

index ae9e0169bfacd4395f333a37ef1b5bf384ca265b..885e67ef96dc0b218825f94d908a7df98e8b8735 100644

--- a/chrome/browser/permissions/permission_bubble_request_impl.h

+++ b/chrome/browser/permissions/permission_bubble_request_impl.h

@@ -38,10 +38,7 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {

base::string16 GetMessageText() const override;

base::string16 GetMessageTextFragment() const override;

bool HasUserGesture() const override;

- // TODO(miguelg) Change this method to GetOrigin()

- GURL GetRequestingHostname() const override;

+ GURL GetOrigin() const override;

// Remember to call RegisterActionTaken for these methods if you are

// overriding them.

void PermissionGranted() override;