chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm - Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_bubble_request_impl.cc ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

index 993dbbf2f2abaee2fa038de9c7f046fb3a94be28..fb8f3ddbcf5d387ddd420167fe8539e9bc9b6f34 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

@@ -340,8 +340,7 @@ class MenuDelegate : public ui::SimpleMenuModel::Delegate {

}

base::scoped_nsobject<NSView> titleView(

- [[self titleWithHostname:requests[0]->GetRequestingHostname().host()]

- retain]);

+ [[self titleWithHostname:requests[0]->GetOrigin().host()] retain]);

[contentView addSubview:titleView];

[titleView setFrameOrigin:NSMakePoint(kHorizontalPadding,

kVerticalPadding + yOffset)];

@@ -541,7 +540,7 @@ class MenuDelegate : public ui::SimpleMenuModel::Delegate {

DCHECK(request);

DCHECK(delegate_);

base::scoped_nsobject<AllowBlockMenuButton> button(

- [[AllowBlockMenuButton alloc] initForURL:request->GetRequestingHostname()

+ [[AllowBlockMenuButton alloc] initForURL:request->GetOrigin()

allowed:allow

index:index

delegate:delegate_]);