chrome/browser/download/download_permission_request.h - Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_permission_request.h

Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc ('k') | chrome/browser/download/download_permission_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_permission_request.h

diff --git a/chrome/browser/download/download_permission_request.h b/chrome/browser/download/download_permission_request.h

index d7a501ac8119de7f4d66394a5e65d88f1b705887..f596cb51fd71c18d082bf27dcbc721fc44892fa9 100644

--- a/chrome/browser/download/download_permission_request.h

+++ b/chrome/browser/download/download_permission_request.h

@@ -25,7 +25,7 @@ class DownloadPermissionRequest : public PermissionBubbleRequest {

base::string16 GetMessageText() const override;

base::string16 GetMessageTextFragment() const override;

bool HasUserGesture() const override;

- GURL GetRequestingHostname() const override;

+ GURL GetOrigin() const override;

void PermissionGranted() override;

void PermissionDenied() override;

void Cancelled() override;

@@ -33,7 +33,7 @@ class DownloadPermissionRequest : public PermissionBubbleRequest {

private:

base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host_;

- GURL request_url_;

+ GURL request_origin_;

DISALLOW_COPY_AND_ASSIGN(DownloadPermissionRequest);

};