Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: chrome/browser/permissions/permission_bubble_request_impl.h

Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_ 5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_
6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_ 6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "chrome/browser/permissions/permission_request_id.h" 10 #include "chrome/browser/permissions/permission_request_id.h"
(...skipping 20 matching lines...) Expand all
31 const base::Closure delete_callback); 31 const base::Closure delete_callback);
32 32
33 ~PermissionBubbleRequestImpl() override; 33 ~PermissionBubbleRequestImpl() override;
34 34
35 // PermissionBubbleRequest: 35 // PermissionBubbleRequest:
36 gfx::VectorIconId GetVectorIconId() const override; 36 gfx::VectorIconId GetVectorIconId() const override;
37 int GetIconId() const override; 37 int GetIconId() const override;
38 base::string16 GetMessageText() const override; 38 base::string16 GetMessageText() const override;
39 base::string16 GetMessageTextFragment() const override; 39 base::string16 GetMessageTextFragment() const override;
40 bool HasUserGesture() const override; 40 bool HasUserGesture() const override;
41 41 GURL GetOrigin() const override;
42 // TODO(miguelg) Change this method to GetOrigin()
43 GURL GetRequestingHostname() const override;
44
45 // Remember to call RegisterActionTaken for these methods if you are 42 // Remember to call RegisterActionTaken for these methods if you are
46 // overriding them. 43 // overriding them.
47 void PermissionGranted() override; 44 void PermissionGranted() override;
48 void PermissionDenied() override; 45 void PermissionDenied() override;
49 void Cancelled() override; 46 void Cancelled() override;
50 void RequestFinished() override; 47 void RequestFinished() override;
51 48
52 protected: 49 protected:
53 void RegisterActionTaken() { action_taken_ = true; } 50 void RegisterActionTaken() { action_taken_ = true; }
54 51
55 private: 52 private:
56 GURL request_origin_; 53 GURL request_origin_;
57 bool user_gesture_; 54 bool user_gesture_;
58 content::PermissionType permission_type_; 55 content::PermissionType permission_type_;
59 std::string display_languages_; 56 std::string display_languages_;
60 57
61 // Called once a decision is made about the permission. 58 // Called once a decision is made about the permission.
62 const PermissionDecidedCallback permission_decided_callback_; 59 const PermissionDecidedCallback permission_decided_callback_;
63 60
64 // Called when the bubble is no longer in use so it can be deleted by 61 // Called when the bubble is no longer in use so it can be deleted by
65 // the caller. 62 // the caller.
66 const base::Closure delete_callback_; 63 const base::Closure delete_callback_;
67 bool is_finished_; 64 bool is_finished_;
68 bool action_taken_; 65 bool action_taken_;
69 66
70 DISALLOW_COPY_AND_ASSIGN(PermissionBubbleRequestImpl); 67 DISALLOW_COPY_AND_ASSIGN(PermissionBubbleRequestImpl);
71 }; 68 };
72 69
73 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_ 70 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_BUBBLE_REQUEST_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/permissions/permission_bubble_request_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698