chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc - Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/register_protocol_handler_permission_request.h ('k') | chrome/browser/download/download_permission_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

diff --git a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

index 1f57a8f8e7ee7d78ec209ad0e2b55a9f631e5d88..47ccaf7de0e4e3112dd627cdb39ade417069dde2 100644

--- a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

+++ b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

@@ -37,7 +37,7 @@ RegisterProtocolHandlerPermissionRequest

bool user_gesture)

: registry_(registry),

handler_(handler),

- url_(url),

+ origin_(url.GetOrigin()),

user_gesture_(user_gesture) {}

RegisterProtocolHandlerPermissionRequest::

@@ -92,8 +92,8 @@ bool RegisterProtocolHandlerPermissionRequest::HasUserGesture() const {

return user_gesture_;

}

-GURL RegisterProtocolHandlerPermissionRequest::GetRequestingHostname() const {

- return url_;

+GURL RegisterProtocolHandlerPermissionRequest::GetOrigin() const {

+ return origin_;

}

void RegisterProtocolHandlerPermissionRequest::PermissionGranted() {