chrome/browser/ui/website_settings/mock_permission_bubble_request.cc - Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/mock_permission_bubble_request.cc

Issue 1637913002: Change PermissionBubbleRequest::GetRequestingHostname to GetOrigin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/mock_permission_bubble_request.h ('k') | chrome/browser/ui/website_settings/permission_bubble_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/mock_permission_bubble_request.cc

diff --git a/chrome/browser/ui/website_settings/mock_permission_bubble_request.cc b/chrome/browser/ui/website_settings/mock_permission_bubble_request.cc

index 0cfd934d2aa8ee0c32fe43b41e1d3025fef86fb3..c4571afa8f426095f199663080bff3568858ba23 100644

--- a/chrome/browser/ui/website_settings/mock_permission_bubble_request.cc

+++ b/chrome/browser/ui/website_settings/mock_permission_bubble_request.cc

@@ -16,7 +16,7 @@ MockPermissionBubbleRequest::MockPermissionBubbleRequest()

text_ = base::ASCIIToUTF16("test");

accept_label_ = base::ASCIIToUTF16("button");

deny_label_ = base::ASCIIToUTF16("button");

- hostname_ = GURL("http://www.google.com");

+ origin_ = GURL("http://www.google.com");

}

MockPermissionBubbleRequest::MockPermissionBubbleRequest(

@@ -28,7 +28,7 @@ MockPermissionBubbleRequest::MockPermissionBubbleRequest(

text_ = base::UTF8ToUTF16(text);

accept_label_ = base::ASCIIToUTF16("button");

deny_label_ = base::ASCIIToUTF16("button");

- hostname_ = GURL("http://www.google.com");

+ origin_ = GURL("http://www.google.com");

}

MockPermissionBubbleRequest::MockPermissionBubbleRequest(

@@ -41,7 +41,7 @@ MockPermissionBubbleRequest::MockPermissionBubbleRequest(

text_ = base::UTF8ToUTF16(text);

accept_label_ = base::ASCIIToUTF16("button");

deny_label_ = base::ASCIIToUTF16("button");

- hostname_ = url;

+ origin_ = url.GetOrigin();

}

MockPermissionBubbleRequest::MockPermissionBubbleRequest(

@@ -55,7 +55,7 @@ MockPermissionBubbleRequest::MockPermissionBubbleRequest(

text_ = base::UTF8ToUTF16(text);

accept_label_ = base::UTF8ToUTF16(accept_label);

deny_label_ = base::UTF8ToUTF16(deny_label);

- hostname_ = GURL("http://www.google.com");

+ origin_ = GURL("http://www.google.com");

}

MockPermissionBubbleRequest::~MockPermissionBubbleRequest() {}

@@ -77,8 +77,8 @@ bool MockPermissionBubbleRequest::HasUserGesture() const {

return user_gesture_;

}

-GURL MockPermissionBubbleRequest::GetRequestingHostname() const {

- return hostname_;

+GURL MockPermissionBubbleRequest::GetOrigin() const {

+ return origin_;

}

void MockPermissionBubbleRequest::PermissionGranted() {