Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 163513002: Have RenderBlockFlow sub-classes' methods call their super-class method properly. (Closed)

Created:
6 years, 10 months ago by mstensho (USE GERRIT)
Modified:
6 years, 10 months ago
CC:
blink-reviews, mstensho+blink_opera.com, philipj_slow, chromiumbugtracker_adobe.com, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Have RenderBlockFlow sub-classes' methods call their super-class method properly. RenderBlockFlowSubclass::foo() should typically call RenderBlockFlow::foo(), not RenderBlock::foo(), unless there are special reasons for bypassing RenderBlockFlow in particular cases. I failed to come up with a test case that illustrates this problem, but RenderListItem::styleDidChange() not calling RenderBlockFlow::styleDidChange() sure looks bad. If it has floats and becomes a BFC, parents, siblings, cousins etc. are not properly told to remove the floats that are now fully contained by the list item. I suppose there would be dangling pointers lying around because of this. BUG=302024 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -61 lines) Patch
M Source/core/rendering/RenderFieldset.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMarquee.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMediaControlElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMultiColumnBlock.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderProgress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRegion.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderRuby.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderRubyRun.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderRubyText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCaption.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 8 chunks +15 lines, -15 lines 0 comments Download
M Source/core/rendering/RenderTextControl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mstensho (USE GERRIT)
6 years, 10 months ago (2014-02-13 13:33:01 UTC) #1
leviw_travelin_and_unemployed
Great! Thank you! LGTM.
6 years, 10 months ago (2014-02-14 01:29:14 UTC) #2
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 10 months ago (2014-02-14 06:19:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/163513002/1
6 years, 10 months ago (2014-02-14 06:19:47 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 08:03:56 UTC) #5
Message was sent while issue was closed.
Change committed as 167161

Powered by Google App Engine
This is Rietveld 408576698