|
Have RenderBlockFlow sub-classes' methods call their super-class method properly.
RenderBlockFlowSubclass::foo() should typically call
RenderBlockFlow::foo(), not RenderBlock::foo(), unless there are
special reasons for bypassing RenderBlockFlow in particular cases.
I failed to come up with a test case that illustrates this problem,
but RenderListItem::styleDidChange() not calling
RenderBlockFlow::styleDidChange() sure looks bad. If it has floats and
becomes a BFC, parents, siblings, cousins etc. are not properly told
to remove the floats that are now fully contained by the list item. I
suppose there would be dangling pointers lying around because of this.
BUG= 302024
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167161
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+61 lines, -61 lines) |
Patch |
|
M |
Source/core/rendering/RenderFieldset.cpp
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderFileUploadControl.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderFlowThread.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderListBox.cpp
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderListItem.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderMarquee.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderMediaControlElements.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderMultiColumnBlock.cpp
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderMultiColumnSet.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderProgress.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderRegion.cpp
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderRuby.cpp
|
View
|
|
6 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderRubyRun.cpp
|
View
|
|
5 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderRubyText.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderTableCaption.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderTableCell.cpp
|
View
|
|
8 chunks |
+15 lines, -15 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderTextControl.cpp
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderTextControlSingleLine.cpp
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderView.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|