Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: Source/core/rendering/RenderFlowThread.cpp

Issue 163513002: Have RenderBlockFlow sub-classes' methods call their super-class method properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 layer()->paint(context, info.rect, info.paintBehavior, 0, region, PaintL ayerTemporaryClipRects); 312 layer()->paint(context, info.rect, info.paintBehavior, 0, region, PaintL ayerTemporaryClipRects);
313 313
314 context->restore(); 314 context->restore();
315 } 315 }
316 } 316 }
317 317
318 bool RenderFlowThread::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumula tedOffset, HitTestAction hitTestAction) 318 bool RenderFlowThread::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumula tedOffset, HitTestAction hitTestAction)
319 { 319 {
320 if (hitTestAction == HitTestBlockBackground) 320 if (hitTestAction == HitTestBlockBackground)
321 return false; 321 return false;
322 return RenderBlock::nodeAtPoint(request, result, locationInContainer, accumu latedOffset, hitTestAction); 322 return RenderBlockFlow::nodeAtPoint(request, result, locationInContainer, ac cumulatedOffset, hitTestAction);
323 } 323 }
324 324
325 bool RenderFlowThread::hitTestFlowThreadPortionInRegion(RenderRegion* region, co nst LayoutRect& flowThreadPortionRect, const LayoutRect& flowThreadPortionOverfl owRect, const HitTestRequest& request, HitTestResult& result, const HitTestLocat ion& locationInContainer, const LayoutPoint& accumulatedOffset) const 325 bool RenderFlowThread::hitTestFlowThreadPortionInRegion(RenderRegion* region, co nst LayoutRect& flowThreadPortionRect, const LayoutRect& flowThreadPortionOverfl owRect, const HitTestRequest& request, HitTestResult& result, const HitTestLocat ion& locationInContainer, const LayoutPoint& accumulatedOffset) const
326 { 326 {
327 LayoutRect regionClippingRect = computeRegionClippingRect(accumulatedOffset, flowThreadPortionRect, flowThreadPortionOverflowRect); 327 LayoutRect regionClippingRect = computeRegionClippingRect(accumulatedOffset, flowThreadPortionRect, flowThreadPortionOverflowRect);
328 if (!regionClippingRect.contains(locationInContainer.point())) 328 if (!regionClippingRect.contains(locationInContainer.point()))
329 return false; 329 return false;
330 330
331 LayoutSize renderFlowThreadOffset; 331 LayoutSize renderFlowThreadOffset;
332 if (style()->isFlippedBlocksWritingMode()) { 332 if (style()->isFlippedBlocksWritingMode()) {
(...skipping 842 matching lines...) Expand 10 before | Expand all | Expand 10 after
1175 { 1175 {
1176 if (!m_renderFlowThread) 1176 if (!m_renderFlowThread)
1177 return; 1177 return;
1178 RenderView* view = m_renderFlowThread->view(); 1178 RenderView* view = m_renderFlowThread->view();
1179 ASSERT(view->flowThreadController()->currentRenderFlowThread() == m_renderFl owThread); 1179 ASSERT(view->flowThreadController()->currentRenderFlowThread() == m_renderFl owThread);
1180 view->flowThreadController()->setCurrentRenderFlowThread(m_previousRenderFlo wThread); 1180 view->flowThreadController()->setCurrentRenderFlowThread(m_previousRenderFlo wThread);
1181 } 1181 }
1182 1182
1183 1183
1184 } // namespace WebCore 1184 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderFileUploadControl.cpp ('k') | Source/core/rendering/RenderListBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698