Source/core/rendering/RenderMultiColumnSet.cpp - Issue 163513002: Have RenderBlockFlow sub-classes' methods call their super-class method properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSet.cpp

Issue 163513002: Have RenderBlockFlow sub-classes' methods call their super-class method properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderMultiColumnSet.cpp

diff --git a/Source/core/rendering/RenderMultiColumnSet.cpp b/Source/core/rendering/RenderMultiColumnSet.cpp

index d66f8896fc4b1a371ef6a9930c9740cabec2b953..a38addba0e3123d948687590b4078adbcbc74a87 100644

--- a/Source/core/rendering/RenderMultiColumnSet.cpp

+++ b/Source/core/rendering/RenderMultiColumnSet.cpp

@@ -386,7 +386,7 @@ void RenderMultiColumnSet::paintObject(PaintInfo& paintInfo, const LayoutPoint&

if (style()->visibility() != VISIBLE)

return;

- RenderBlock::paintObject(paintInfo, paintOffset);

+ RenderBlockFlow::paintObject(paintInfo, paintOffset);

// FIXME: Right now we're only painting in the foreground phase.

// Columns should technically respect phases and allow for background/float/foreground overlap etc., just like

« no previous file with comments | « Source/core/rendering/RenderMultiColumnBlock.cpp ('k') | Source/core/rendering/RenderProgress.cpp » ('j') | no next file with comments »