Source/core/rendering/RenderFlowThread.cpp - Issue 163513002: Have RenderBlockFlow sub-classes' methods call their super-class method properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlowThread.cpp

Issue 163513002: Have RenderBlockFlow sub-classes' methods call their super-class method properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderFlowThread.cpp

diff --git a/Source/core/rendering/RenderFlowThread.cpp b/Source/core/rendering/RenderFlowThread.cpp

index 2e9bb88992a02b0472d123962405a4e22b936481..8bd2ada476a163c9b66751ef643f5eb377543740 100644

--- a/Source/core/rendering/RenderFlowThread.cpp

+++ b/Source/core/rendering/RenderFlowThread.cpp

@@ -319,7 +319,7 @@ bool RenderFlowThread::nodeAtPoint(const HitTestRequest& request, HitTestResult&

{

if (hitTestAction == HitTestBlockBackground)

return false;

- return RenderBlock::nodeAtPoint(request, result, locationInContainer, accumulatedOffset, hitTestAction);

+ return RenderBlockFlow::nodeAtPoint(request, result, locationInContainer, accumulatedOffset, hitTestAction);

}

bool RenderFlowThread::hitTestFlowThreadPortionInRegion(RenderRegion* region, const LayoutRect& flowThreadPortionRect, const LayoutRect& flowThreadPortionOverflowRect, const HitTestRequest& request, HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset) const

« no previous file with comments | « Source/core/rendering/RenderFileUploadControl.cpp ('k') | Source/core/rendering/RenderListBox.cpp » ('j') | no next file with comments »