Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 16337005: Deprecate FACTORY helper macro. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Deprecate FACTORY helper macro. This removes the FACTORY helper macro to avoid accidental TLS access when using the factory. Most internal code has access to the Isolate by now whereas tests which are not performance critical still heavily use TLS access through explicit Isolate::Current() calls. R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -240 lines) Patch
M src/api.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/api.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ast.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/bootstrapper.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/compiler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/d8.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/debug.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M src/execution.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 6 chunks +8 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/ic-ia32.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/jsregexp.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/liveedit.cc View 7 chunks +12 lines, -9 lines 0 comments Download
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M src/objects.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M src/parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/string-stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/stub-cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 15 chunks +26 lines, -15 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 4 chunks +17 lines, -13 lines 0 comments Download
M test/cctest/test-debug.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/test-dictionary.cc View 7 chunks +19 lines, -13 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M test/cctest/test-heap.cc View 36 chunks +80 lines, -46 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 12 chunks +32 lines, -17 lines 0 comments Download
M test/cctest/test-random.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/test-strings.cc View 24 chunks +41 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 6 months ago (2013-06-03 16:15:18 UTC) #1
Sven Panne
lgtm
7 years, 6 months ago (2013-06-04 08:05:24 UTC) #2
Michael Starzinger
7 years, 6 months ago (2013-06-04 10:30:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14931 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698