Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 16337005: Deprecate FACTORY helper macro. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 640 matching lines...) Expand 10 before | Expand all | Expand 10 after
651 // Equality is almost reflexive (everything but NaN), so this is a test 651 // Equality is almost reflexive (everything but NaN), so this is a test
652 // for "identity and not NaN". 652 // for "identity and not NaN".
653 static void EmitIdenticalObjectComparison(MacroAssembler* masm, 653 static void EmitIdenticalObjectComparison(MacroAssembler* masm,
654 Label* slow, 654 Label* slow,
655 Condition cond) { 655 Condition cond) {
656 Label not_identical; 656 Label not_identical;
657 Label heap_number, return_equal; 657 Label heap_number, return_equal;
658 __ cmp(r0, r1); 658 __ cmp(r0, r1);
659 __ b(ne, &not_identical); 659 __ b(ne, &not_identical);
660 660
661 // Test for NaN. Sadly, we can't just compare to FACTORY->nan_value(), 661 // Test for NaN. Sadly, we can't just compare to Factory::nan_value(),
662 // so we do the second best thing - test it ourselves. 662 // so we do the second best thing - test it ourselves.
663 // They are both equal and they are not both Smis so both of them are not 663 // They are both equal and they are not both Smis so both of them are not
664 // Smis. If it's not a heap number, then return equal. 664 // Smis. If it's not a heap number, then return equal.
665 if (cond == lt || cond == gt) { 665 if (cond == lt || cond == gt) {
666 __ CompareObjectType(r0, r4, r4, FIRST_SPEC_OBJECT_TYPE); 666 __ CompareObjectType(r0, r4, r4, FIRST_SPEC_OBJECT_TYPE);
667 __ b(ge, slow); 667 __ b(ge, slow);
668 } else { 668 } else {
669 __ CompareObjectType(r0, r4, r4, HEAP_NUMBER_TYPE); 669 __ CompareObjectType(r0, r4, r4, HEAP_NUMBER_TYPE);
670 __ b(eq, &heap_number); 670 __ b(eq, &heap_number);
671 // Comparing JS objects with <=, >= is complicated. 671 // Comparing JS objects with <=, >= is complicated.
(...skipping 6661 matching lines...) Expand 10 before | Expand all | Expand 10 after
7333 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET); 7333 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET);
7334 } 7334 }
7335 } 7335 }
7336 7336
7337 7337
7338 #undef __ 7338 #undef __
7339 7339
7340 } } // namespace v8::internal 7340 } } // namespace v8::internal
7341 7341
7342 #endif // V8_TARGET_ARCH_ARM 7342 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698