src/ast.cc - Issue 16337005: Deprecate FACTORY helper macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 16337005: Deprecate FACTORY helper macro. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index e27feec1a63dbed8f1882d347144ff867664a859..18ac6ededed440ef60a7ea2f94ff6587bc5019d3 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -1183,6 +1183,7 @@ void AstConstructionVisitor::VisitCallRuntime(CallRuntime* node) {

Handle<String> Literal::ToString() {

if (handle_->IsString()) return Handle<String>::cast(handle_);

+ Factory* factory = Isolate::Current()->factory();

ASSERT(handle_->IsNumber());

char arr[100];

Vector<char> buffer(arr, ARRAY_SIZE(arr));

@@ -1194,7 +1195,7 @@ Handle<String> Literal::ToString() {

} else {

str = DoubleToCString(handle_->Number(), buffer);

}

- return FACTORY->NewStringFromAscii(CStrVector(str));

+ return factory->NewStringFromAscii(CStrVector(str));

}

« no previous file with comments | « src/arm/regexp-macro-assembler-arm.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »