Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: src/ast.cc

Issue 16337005: Deprecate FACTORY helper macro. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/regexp-macro-assembler-arm.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1165 matching lines...) Expand 10 before | Expand all | Expand 10 after
1176 } 1176 }
1177 1177
1178 #undef REGULAR_NODE 1178 #undef REGULAR_NODE
1179 #undef DONT_OPTIMIZE_NODE 1179 #undef DONT_OPTIMIZE_NODE
1180 #undef DONT_SELFOPTIMIZE_NODE 1180 #undef DONT_SELFOPTIMIZE_NODE
1181 #undef DONT_CACHE_NODE 1181 #undef DONT_CACHE_NODE
1182 1182
1183 1183
1184 Handle<String> Literal::ToString() { 1184 Handle<String> Literal::ToString() {
1185 if (handle_->IsString()) return Handle<String>::cast(handle_); 1185 if (handle_->IsString()) return Handle<String>::cast(handle_);
1186 Factory* factory = Isolate::Current()->factory();
1186 ASSERT(handle_->IsNumber()); 1187 ASSERT(handle_->IsNumber());
1187 char arr[100]; 1188 char arr[100];
1188 Vector<char> buffer(arr, ARRAY_SIZE(arr)); 1189 Vector<char> buffer(arr, ARRAY_SIZE(arr));
1189 const char* str; 1190 const char* str;
1190 if (handle_->IsSmi()) { 1191 if (handle_->IsSmi()) {
1191 // Optimization only, the heap number case would subsume this. 1192 // Optimization only, the heap number case would subsume this.
1192 OS::SNPrintF(buffer, "%d", Smi::cast(*handle_)->value()); 1193 OS::SNPrintF(buffer, "%d", Smi::cast(*handle_)->value());
1193 str = arr; 1194 str = arr;
1194 } else { 1195 } else {
1195 str = DoubleToCString(handle_->Number(), buffer); 1196 str = DoubleToCString(handle_->Number(), buffer);
1196 } 1197 }
1197 return FACTORY->NewStringFromAscii(CStrVector(str)); 1198 return factory->NewStringFromAscii(CStrVector(str));
1198 } 1199 }
1199 1200
1200 1201
1201 } } // namespace v8::internal 1202 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/regexp-macro-assembler-arm.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698