src/api.h - Issue 16337005: Deprecate FACTORY helper macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.h

Issue 16337005: Deprecate FACTORY helper macro. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.h

diff --git a/src/api.h b/src/api.h

index 62380ce651249d86548c37679c9b2deb248c1bfd..2f33599e427bd3c6cb17ecd333c2799481f4a0cf 100644

--- a/src/api.h

+++ b/src/api.h

@@ -126,8 +126,9 @@ template <typename T> inline T ToCData(v8::internal::Object* obj) {

template <typename T>

inline v8::internal::Handle<v8::internal::Object> FromCData(T obj) {

+ v8::internal::Isolate* isolate = v8::internal::Isolate::Current();

STATIC_ASSERT(sizeof(T) == sizeof(v8::internal::Address));

- return FACTORY->NewForeign(

+ return isolate->factory()->NewForeign(

reinterpret_cast<v8::internal::Address>(reinterpret_cast<intptr_t>(obj)));

}

« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »