Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Side by Side Diff: src/hydrogen-instructions.h

Issue 16337005: Deprecate FACTORY helper macro. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3131 matching lines...) Expand 10 before | Expand all | Expand 10 after
3142 HConstant(Handle<Object> handle, 3142 HConstant(Handle<Object> handle,
3143 UniqueValueId unique_id, 3143 UniqueValueId unique_id,
3144 Representation r, 3144 Representation r,
3145 HType type, 3145 HType type,
3146 bool is_internalized_string, 3146 bool is_internalized_string,
3147 bool is_not_in_new_space, 3147 bool is_not_in_new_space,
3148 bool boolean_value); 3148 bool boolean_value);
3149 3149
3150 Handle<Object> handle() { 3150 Handle<Object> handle() {
3151 if (handle_.is_null()) { 3151 if (handle_.is_null()) {
3152 Factory* factory = Isolate::Current()->factory();
3152 // Default arguments to is_not_in_new_space depend on this heap number 3153 // Default arguments to is_not_in_new_space depend on this heap number
3153 // to be tenured so that it's guaranteed not be be located in new space. 3154 // to be tenured so that it's guaranteed not be be located in new space.
3154 handle_ = FACTORY->NewNumber(double_value_, TENURED); 3155 handle_ = factory->NewNumber(double_value_, TENURED);
3155 } 3156 }
3156 ALLOW_HANDLE_DEREF(Isolate::Current(), "smi check"); 3157 ALLOW_HANDLE_DEREF(Isolate::Current(), "smi check");
3157 ASSERT(has_int32_value_ || !handle_->IsSmi()); 3158 ASSERT(has_int32_value_ || !handle_->IsSmi());
3158 return handle_; 3159 return handle_;
3159 } 3160 }
3160 3161
3161 bool IsSpecialDouble() const { 3162 bool IsSpecialDouble() const {
3162 return has_double_value_ && 3163 return has_double_value_ &&
3163 (BitCast<int64_t>(double_value_) == BitCast<int64_t>(-0.0) || 3164 (BitCast<int64_t>(double_value_) == BitCast<int64_t>(-0.0) ||
3164 FixedDoubleArray::is_the_hole_nan(double_value_) || 3165 FixedDoubleArray::is_the_hole_nan(double_value_) ||
(...skipping 3335 matching lines...) Expand 10 before | Expand all | Expand 10 after
6500 virtual bool IsDeletable() const { return true; } 6501 virtual bool IsDeletable() const { return true; }
6501 }; 6502 };
6502 6503
6503 6504
6504 #undef DECLARE_INSTRUCTION 6505 #undef DECLARE_INSTRUCTION
6505 #undef DECLARE_CONCRETE_INSTRUCTION 6506 #undef DECLARE_CONCRETE_INSTRUCTION
6506 6507
6507 } } // namespace v8::internal 6508 } } // namespace v8::internal
6508 6509
6509 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6510 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698