[BackgroundSync Cleanup] Remove periodic sync code

[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms. There are still functions with names like "FireOneShot" as opposed to just "Fire." If those are renamed, it will be in a followup.

* Remove power monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/

BUG=552031
Committed: https://crrev.com/323a239968fdbfb6e86247cdc2f536e8bdaf0e78
Cr-Commit-Position: refs/heads/master@{#371307}

[jkarlin, 2016-01-21 18:02:41]

Description was changed from

==========
[BackgroundSync Cleanup] Remove periodic sync code

Removes code related to periodic sync.

BUG=552031
==========

to

==========
[BackgroundSync Cleanup] Remove periodic sync code

Removed periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

BUG=552031
==========

[jkarlin, 2016-01-21 18:02:52]

Description was changed from

==========
[BackgroundSync Cleanup] Remove periodic sync code

Removed periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

BUG=552031
==========

to

==========
[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

BUG=552031
==========

[jkarlin, 2016-01-21 19:49:55]

jkarlin@chromium.org changed reviewers:
+ iclelland@chromium.org, tsepez@chromium.org

[jkarlin, 2016-01-21 19:50:42]

iclelland@ Please review everything
tsepez@ Please review the mojom files

Thanks!

[jkarlin, 2016-01-21 19:54:19]

Description was changed from

==========
[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

BUG=552031
==========

to

==========
[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

* Remove Power Monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/

BUG=552031
==========

[jkarlin, 2016-01-21 19:54:59]

Description was changed from

==========
[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

* Remove Power Monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/

BUG=552031
==========

to

==========
[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

* Remove power monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/


BUG=552031
==========

[Tom Sepez, 2016-01-21 19:59:36]

mojom LGTM

[iclelland, 2016-01-22 19:20:42]

LGTM with formatting/comment nits, and one question about a deleted test.

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
File content/browser/background_sync/background_sync_manager.cc (right):

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_manager.cc:173: : value_("o_" +
tag) {}
Should we add a comment here to explain why we don't just use |tag| by itself?
It won't be clear at all after this CL lands.

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
File content/browser/background_sync/background_sync_manager.h (right):

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_manager.h:80: // with
Re-wrap

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_manager.h:90: //
|sw_registration_id|. Calls
Re-wrap

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
File content/browser/background_sync/background_sync_manager_unittest.cc (left):

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_manager_unittest.cc:692:
TEST_F(BackgroundSyncManagerTest, RegisterOverwrites) {
Why is this test gone? Could we change it to overwrite network state instead?

https://codereview.chromium.org/1614063002/diff/40001/content/common/backgrou...
File content/common/background_sync_service.mojom (right):

https://codereview.chromium.org/1614063002/diff/40001/content/common/backgrou...
content/common/background_sync_service.mojom:39: GetRegistration(string tag,
Combine with next line?

https://codereview.chromium.org/1614063002/diff/40001/content/common/backgrou...
content/common/background_sync_service.mojom:42: GetRegistrations(
Ditto

https://codereview.chromium.org/1614063002/diff/40001/content/common/backgrou...
content/common/background_sync_service.mojom:47: GetPermissionStatus(
Ditto

[jkarlin, 2016-01-22 19:45:46]

Thanks!

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
File content/browser/background_sync/background_sync_manager.cc (right):

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_manager.cc:173: : value_("o_" +
tag) {}
On 2016/01/22 19:20:41, iclelland wrote:
> Should we add a comment here to explain why we don't just use |tag| by itself?
> It won't be clear at all after this CL lands.

Good idea. Done.

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
File content/browser/background_sync/background_sync_manager.h (right):

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_manager.h:80: // with
On 2016/01/22 19:20:41, iclelland wrote:
> Re-wrap

Done.

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_manager.h:90: //
|sw_registration_id|. Calls
On 2016/01/22 19:20:41, iclelland wrote:
> Re-wrap

Done.

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
File content/browser/background_sync/background_sync_manager_unittest.cc (left):

https://codereview.chromium.org/1614063002/diff/40001/content/browser/backgro...
content/browser/background_sync/background_sync_manager_unittest.cc:692:
TEST_F(BackgroundSyncManagerTest, RegisterOverwrites) {
On 2016/01/22 19:20:41, iclelland wrote:
> Why is this test gone? Could we change it to overwrite network state instead?

Because it's equivalent to
BackgroundSyncManagerTest.OverwritePendingRegistration. There is a subtle
difference, which is that this test also verifies that the handle_id increases.
I've added that to OverwritePendingRegistration.

https://codereview.chromium.org/1614063002/diff/40001/content/common/backgrou...
File content/common/background_sync_service.mojom (right):

https://codereview.chromium.org/1614063002/diff/40001/content/common/backgrou...
content/common/background_sync_service.mojom:39: GetRegistration(string tag,
On 2016/01/22 19:20:42, iclelland wrote:
> Combine with next line?

Thanks, git cl format doesn't handle mojom yet :)

https://codereview.chromium.org/1614063002/diff/40001/content/common/backgrou...
content/common/background_sync_service.mojom:42: GetRegistrations(
On 2016/01/22 19:20:42, iclelland wrote:
> Ditto

Done.

https://codereview.chromium.org/1614063002/diff/40001/content/common/backgrou...
content/common/background_sync_service.mojom:47: GetPermissionStatus(
On 2016/01/22 19:20:42, iclelland wrote:
> Ditto

Done.

[jkarlin, 2016-01-25 12:12:41]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-01-25 12:12:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
iclelland@chromium.org
Link to the patchset: https://codereview.chromium.org/1614063002/#ps60001
(title: "Address comments from PS3")

[commit-bot: I haz the power, 2016-01-25 12:12:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614063002/60001

[commit-bot: I haz the power, 2016-01-25 12:21:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 12:21:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jkarlin, 2016-01-25 12:24:08]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2016-01-25 12:25:53]

jkarlin@chromium.org changed reviewers:
+ isherman@chromium.org

[jkarlin, 2016-01-25 12:25:54]

isherman@: PTAL at histograms.xml, thanks!

[Ilya Sherman, 2016-01-25 19:41:47]

histograms.xml lgtm

[jkarlin, 2016-01-25 19:45:24]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2016-01-25 19:46:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1614063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1614063002/60001

[commit-bot: I haz the power, 2016-01-25 20:51:01]

Description was changed from

==========
[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

* Remove power monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/


BUG=552031
==========

to

==========
[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

* Remove power monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/


BUG=552031
==========

[commit-bot: I haz the power, 2016-01-25 20:51:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-25 20:52:30]

Description was changed from

==========
[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

* Remove power monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/


BUG=552031
==========

to

==========
[BackgroundSync Cleanup] Remove periodic sync code

Remove periodic information from structs, protobufs, methods, and histograms.
There are still functions with names like "FireOneShot" as opposed to just
"Fire." If those are renamed, it will be in a followup.

* Remove power monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/

BUG=552031

Committed: https://crrev.com/323a239968fdbfb6e86247cdc2f536e8bdaf0e78
Cr-Commit-Position: refs/heads/master@{#371307}
==========

[commit-bot: I haz the power, 2016-01-25 20:52:31]

Patchset 4 (id:??) landed as
https://crrev.com/323a239968fdbfb6e86247cdc2f536e8bdaf0e78
Cr-Commit-Position: refs/heads/master@{#371307}