third_party/WebKit/Source/modules/background_sync/SyncManager.cpp - Issue 1614063002: [BackgroundSync Cleanup] Remove periodic sync code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

Issue 1614063002: [BackgroundSync Cleanup] Remove periodic sync code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@purge_power

Patch Set: Address comments from PS3 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/background_sync/SyncManager.h ('k') | third_party/WebKit/public/platform/modules/background_sync/WebSyncProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

diff --git a/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp b/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

index 1c386039294cd0f71c270a94e348243a92c40925..883e379154a254d86844faac02b282251a4787ee 100644

--- a/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

+++ b/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

@@ -58,9 +58,7 @@ ScriptPromise SyncManager::registerFunction(ScriptState* scriptState, ExecutionC

WebSyncRegistration* webSyncRegistration = new WebSyncRegistration(

WebSyncRegistration::UNREGISTERED_SYNC_ID /* id */,

- WebSyncRegistration::PeriodicityOneShot,

tag,

- 0 /* minPeriod */,

WebSyncRegistration::NetworkStateOnline /* networkState */

);

backgroundSyncProvider()->registerBackgroundSync(webSyncRegistration, m_registration->webRegistration(), context->isServiceWorkerGlobalScope(), new SyncRegistrationCallbacks(resolver, m_registration));

@@ -73,7 +71,7 @@ ScriptPromise SyncManager::getTags(ScriptState* scriptState)

ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

- backgroundSyncProvider()->getRegistrations(WebSyncRegistration::PeriodicityOneShot, m_registration->webRegistration(), new SyncGetRegistrationsCallbacks(resolver, m_registration));

+ backgroundSyncProvider()->getRegistrations(m_registration->webRegistration(), new SyncGetRegistrationsCallbacks(resolver, m_registration));

return promise;

}