Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: content/browser/background_sync/background_sync_metrics.cc

Issue 1614063002: [BackgroundSync Cleanup] Remove periodic sync code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@purge_power
Patch Set: Address comments from PS3 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_metrics.cc
diff --git a/content/browser/background_sync/background_sync_metrics.cc b/content/browser/background_sync/background_sync_metrics.cc
index 20b3a6651a395da496ee75f067e819b7afa4dccb..8198815c3f043a127e959a8cc2503cd6e17625a9 100644
--- a/content/browser/background_sync/background_sync_metrics.cc
+++ b/content/browser/background_sync/background_sync_metrics.cc
@@ -33,40 +33,18 @@ ResultPattern EventResultToResultPattern(bool success,
namespace content {
// static
-void BackgroundSyncMetrics::RecordEventStarted(SyncPeriodicity periodicity,
- bool started_in_foreground) {
- switch (periodicity) {
- case SYNC_ONE_SHOT:
- UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Event.OneShotStartedInForeground",
- started_in_foreground);
- return;
- case SYNC_PERIODIC:
- UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Event.PeriodicStartedInForeground",
- started_in_foreground);
- return;
- }
- NOTREACHED();
+void BackgroundSyncMetrics::RecordEventStarted(bool started_in_foreground) {
+ UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Event.OneShotStartedInForeground",
+ started_in_foreground);
}
// static
-void BackgroundSyncMetrics::RecordEventResult(SyncPeriodicity periodicity,
- bool success,
+void BackgroundSyncMetrics::RecordEventResult(bool success,
bool finished_in_foreground) {
- switch (periodicity) {
- case SYNC_ONE_SHOT:
- UMA_HISTOGRAM_ENUMERATION(
- "BackgroundSync.Event.OneShotResultPattern",
- EventResultToResultPattern(success, finished_in_foreground),
- RESULT_PATTERN_MAX + 1);
- return;
- case SYNC_PERIODIC:
- UMA_HISTOGRAM_ENUMERATION(
- "BackgroundSync.Event.PeriodicResultPattern",
- EventResultToResultPattern(success, finished_in_foreground),
- RESULT_PATTERN_MAX + 1);
- return;
- }
- NOTREACHED();
+ UMA_HISTOGRAM_ENUMERATION(
+ "BackgroundSync.Event.OneShotResultPattern",
+ EventResultToResultPattern(success, finished_in_foreground),
+ RESULT_PATTERN_MAX + 1);
}
// static
@@ -84,62 +62,30 @@ void BackgroundSyncMetrics::RecordBatchSyncEventComplete(
// static
void BackgroundSyncMetrics::CountRegisterSuccess(
- SyncPeriodicity periodicity,
RegistrationCouldFire registration_could_fire,
RegistrationIsDuplicate registration_is_duplicate) {
- switch (periodicity) {
- case SYNC_ONE_SHOT:
- UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Registration.OneShot",
- BACKGROUND_SYNC_STATUS_OK,
- BACKGROUND_SYNC_STATUS_MAX + 1);
- UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Registration.OneShot.CouldFire",
- registration_could_fire == REGISTRATION_COULD_FIRE);
- UMA_HISTOGRAM_BOOLEAN(
- "BackgroundSync.Registration.OneShot.IsDuplicate",
- registration_is_duplicate == REGISTRATION_IS_DUPLICATE);
- return;
- case SYNC_PERIODIC:
- UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Registration.Periodic",
- BACKGROUND_SYNC_STATUS_OK,
- BACKGROUND_SYNC_STATUS_MAX + 1);
- UMA_HISTOGRAM_BOOLEAN(
- "BackgroundSync.Registration.Periodic.IsDuplicate",
- registration_is_duplicate == REGISTRATION_IS_DUPLICATE);
- return;
- }
- NOTREACHED();
+ UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Registration.OneShot",
+ BACKGROUND_SYNC_STATUS_OK,
+ BACKGROUND_SYNC_STATUS_MAX + 1);
+ UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Registration.OneShot.CouldFire",
+ registration_could_fire == REGISTRATION_COULD_FIRE);
+ UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Registration.OneShot.IsDuplicate",
+ registration_is_duplicate == REGISTRATION_IS_DUPLICATE);
+ return;
}
// static
-void BackgroundSyncMetrics::CountRegisterFailure(SyncPeriodicity periodicity,
- BackgroundSyncStatus result) {
- switch (periodicity) {
- case SYNC_ONE_SHOT:
- UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Registration.OneShot", result,
- BACKGROUND_SYNC_STATUS_MAX + 1);
- return;
- case SYNC_PERIODIC:
- UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Registration.Periodic", result,
- BACKGROUND_SYNC_STATUS_MAX + 1);
- return;
- }
- NOTREACHED();
+void BackgroundSyncMetrics::CountRegisterFailure(BackgroundSyncStatus result) {
+ UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Registration.OneShot", result,
+ BACKGROUND_SYNC_STATUS_MAX + 1);
+ return;
}
// static
-void BackgroundSyncMetrics::CountUnregister(SyncPeriodicity periodicity,
- BackgroundSyncStatus result) {
- switch (periodicity) {
- case SYNC_ONE_SHOT:
- UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Unregistration.OneShot", result,
- BACKGROUND_SYNC_STATUS_MAX + 1);
- return;
- case SYNC_PERIODIC:
- UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Unregistration.Periodic",
- result, BACKGROUND_SYNC_STATUS_MAX + 1);
- return;
- }
- NOTREACHED();
+void BackgroundSyncMetrics::CountUnregister(BackgroundSyncStatus result) {
+ UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Unregistration.OneShot", result,
+ BACKGROUND_SYNC_STATUS_MAX + 1);
+ return;
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698