Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: content/browser/background_sync/background_sync_manager.h

Issue 1614063002: [BackgroundSync Cleanup] Remove periodic sync code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@purge_power
Patch Set: Address comments from PS3 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_manager.h
diff --git a/content/browser/background_sync/background_sync_manager.h b/content/browser/background_sync/background_sync_manager.h
index 5f1c7620c7bae3f292fb1ea69cc996ea5237adaa..8d92f807966daa9a89a1ffb1e9379f98883ff0a7 100644
--- a/content/browser/background_sync/background_sync_manager.h
+++ b/content/browser/background_sync/background_sync_manager.h
@@ -64,9 +64,9 @@ class CONTENT_EXPORT BackgroundSyncManager
~BackgroundSyncManager() override;
// Stores the given background sync registration and adds it to the scheduling
- // queue. It will overwrite an existing registration with the same tag and
- // periodicity unless they're identical (save for the id). Calls |callback|
- // with BACKGROUND_SYNC_STATUS_OK and the accepted registration on success.
+ // queue. It will overwrite an existing registration with the same tag unless
+ // they're identical (save for the id). Calls |callback| with
+ // BACKGROUND_SYNC_STATUS_OK and the accepted registration on success.
// The accepted registration will have a unique id. It may also have altered
// parameters if the user or UA chose different parameters than those
// supplied.
@@ -76,22 +76,19 @@ class CONTENT_EXPORT BackgroundSyncManager
const StatusAndRegistrationCallback& callback);
// Finds the background sync registration associated with
- // |sw_registration_id|, periodicity |periodicity|, and tag
- // |sync_registration_tag|. Calls |callback| with
- // BACKGROUND_SYNC_STATUS_NOT_FOUND if it doesn't exist. Calls |callback| with
- // BACKGROUND_SYNC_STATUS_OK on success. If the callback's status
- // is not BACKGROUND_SYNC_STATUS_OK then the callback's RegistrationHandle
- // will be nullptr.
+ // |sw_registration_id|, and tag |sync_registration_tag|. Calls |callback|
+ // with BACKGROUND_SYNC_STATUS_NOT_FOUND if it doesn't exist. Calls |callback|
+ // with BACKGROUND_SYNC_STATUS_OK on success. If the callback's status is not
+ // BACKGROUND_SYNC_STATUS_OK then the callback's RegistrationHandle will be
+ // nullptr.
void GetRegistration(int64_t sw_registration_id,
const std::string& sync_registration_tag,
- SyncPeriodicity periodicity,
const StatusAndRegistrationCallback& callback);
// Finds the background sync registrations associated with
- // |sw_registration_id| and periodicity |periodicity|. Calls
- // |callback| with BACKGROUND_SYNC_STATUS_OK on success.
+ // |sw_registration_id|. Calls |callback| with BACKGROUND_SYNC_STATUS_OK on
+ // success.
void GetRegistrations(int64_t sw_registration_id,
- SyncPeriodicity periodicity,
const StatusAndRegistrationsCallback& callback);
// Given a HandleId |handle_id|, return a new handle for the same
@@ -162,7 +159,7 @@ class CONTENT_EXPORT BackgroundSyncManager
public:
explicit RegistrationKey(const BackgroundSyncRegistration& registration);
explicit RegistrationKey(const BackgroundSyncRegistrationOptions& options);
- RegistrationKey(const std::string& tag, SyncPeriodicity periodicity);
+ RegistrationKey(const std::string& tag);
RegistrationKey(const RegistrationKey& other) = default;
RegistrationKey& operator=(const RegistrationKey& other) = default;
@@ -266,10 +263,9 @@ class CONTENT_EXPORT BackgroundSyncManager
const StatusAndRegistrationCallback& callback,
ServiceWorkerStatusCode status);
- // Removes the background sync with periodicity |periodicity| and id
- // |sync_registration_id|. Calls |callback| with
- // BACKGROUND_SYNC_STATUS_NOT_FOUND if no match is found. Calls |callback|
- // with BACKGROUND_SYNC_STATUS_OK on success.
+ // Removes the background sync with id |sync_registration_id|. Calls
+ // |callback| with BACKGROUND_SYNC_STATUS_NOT_FOUND if no match is found.
+ // Calls |callback| with BACKGROUND_SYNC_STATUS_OK on success.
void Unregister(int64_t sw_registration_id,
BackgroundSyncRegistrationHandle::HandleId handle_id,
const StatusCallback& callback);
@@ -277,10 +273,8 @@ class CONTENT_EXPORT BackgroundSyncManager
int64_t sw_registration_id,
const RegistrationKey& key,
BackgroundSyncRegistration::RegistrationId sync_registration_id,
- SyncPeriodicity periodicity,
const StatusCallback& callback);
void UnregisterDidStore(int64_t sw_registration_id,
- SyncPeriodicity periodicity,
const StatusCallback& callback,
ServiceWorkerStatusCode status);
@@ -302,7 +296,6 @@ class CONTENT_EXPORT BackgroundSyncManager
// GetRegistrations callbacks
void GetRegistrationsImpl(int64_t sw_registration_id,
- SyncPeriodicity periodicity,
const StatusAndRegistrationsCallback& callback);
bool AreOptionConditionsMet(const BackgroundSyncRegistrationOptions& options);

Powered by Google App Engine
This is Rietveld 408576698