Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1613053004: [Background Sync Cleanup] Remove mention of oneshot (Closed)

Created:
4 years, 11 months ago by jkarlin
Modified:
4 years, 11 months ago
Reviewers:
iclelland
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, Peter Beverloo, maxbogue+watch_chromium.org, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, plaree+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@purge_periodic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Background Sync Cleanup] Remove mention of oneshot There is only one periodicity now, refer to it as a registration instead of a one-shot registration. If we add periodic back in the future we can refer to those as periodic registrations. * Remove power monitor: https://codereview.chromium.org/1617063002/ * Remove periodic code: https://codereview.chromium.org/1614063002/ * Remove mention of one-shot: https://codereview.chromium.org/1613053004/ BUG=552031 Committed: https://crrev.com/6f508594cbf763eb57f862543c2f36e932926f90 Cr-Commit-Position: refs/heads/master@{#371357}

Patch Set 1 #

Patch Set 2 : Fix browser tests #

Patch Set 3 : Some browser test refactoring #

Patch Set 4 : One more rename #

Patch Set 5 : Rebase #

Patch Set 6 : Nit #

Messages

Total messages: 11 (6 generated)
jkarlin
iclelland@ PTAL, thanks!
4 years, 11 months ago (2016-01-22 15:38:06 UTC) #4
iclelland
Sorry for the delay -- this lgtm
4 years, 11 months ago (2016-01-25 12:30:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613053004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613053004/100001
4 years, 11 months ago (2016-01-25 22:21:13 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 11 months ago (2016-01-26 00:02:02 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:04:53 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6f508594cbf763eb57f862543c2f36e932926f90
Cr-Commit-Position: refs/heads/master@{#371357}

Powered by Google App Engine
This is Rietveld 408576698