Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1617063002: [BackgroundSync Cleanup] Remove power observer (Closed)

Created:
4 years, 11 months ago by jkarlin
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez, iclelland
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, plaree+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BackgroundSync Cleanup] Remove the unused power observer. * Remove power monitor: https://codereview.chromium.org/1617063002/ * Remove periodic code: https://codereview.chromium.org/1614063002/ * Remove mention of one-shot: https://codereview.chromium.org/1613053004/ BUG=552031 Committed: https://crrev.com/ce56df4e76af412e75b758fe33b304bc4971ab7a Cr-Commit-Position: refs/heads/master@{#371004}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : More to remove #

Patch Set 4 : Found more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -420 lines) Patch
M content/browser/background_sync/background_sync.proto View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.h View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 1 6 chunks +1 line, -13 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 1 2 3 14 chunks +11 lines, -88 lines 0 comments Download
D content/browser/background_sync/background_sync_power_observer.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/background_sync/background_sync_power_observer.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D content/browser/background_sync/background_sync_power_observer_unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M content/browser/background_sync/background_sync_registration_options.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/background_sync/background_sync_registration_options.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/background_sync/background_sync_service_impl.cc View 1 3 chunks +0 lines, -10 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 1 2 3 4 chunks +0 lines, -12 lines 0 comments Download
M content/child/background_sync/background_sync_type_converters.h View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M content/child/background_sync/background_sync_type_converters.cc View 1 2 4 chunks +0 lines, -28 lines 0 comments Download
M content/child/background_sync/background_sync_type_converters_unittest.cc View 1 2 9 chunks +2 lines, -34 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/background_sync.mojom View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncManager.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/platform/modules/background_sync/WebSyncRegistration.h View 1 2 3 chunks +1 line, -10 lines 0 comments Download

Dependent Patchsets:

Issue 1614063002 Patch 20001
Issue 1614063002 Patch 40001
Issue 1614063002 Patch 60001

Messages

Total messages: 16 (9 generated)
jkarlin
iclelland@: PTAL at everything, thanks!
4 years, 11 months ago (2016-01-21 18:58:51 UTC) #4
jkarlin
tsepez@chromium.org: Please review changes in background_sync.mojom, thanks!
4 years, 11 months ago (2016-01-21 19:05:33 UTC) #7
Tom Sepez
RS LGTM on deleting code from .mojom.
4 years, 11 months ago (2016-01-21 19:06:57 UTC) #8
iclelland
Go less code! LGTM
4 years, 11 months ago (2016-01-22 18:14:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617063002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617063002/60001
4 years, 11 months ago (2016-01-22 18:15:21 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-22 18:59:01 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 19:00:36 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ce56df4e76af412e75b758fe33b304bc4971ab7a
Cr-Commit-Position: refs/heads/master@{#371004}

Powered by Google App Engine
This is Rietveld 408576698