content/browser/background_sync/background_sync_service_impl.h - Issue 1614063002: [BackgroundSync Cleanup] Remove periodic sync code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_service_impl.h

Issue 1614063002: [BackgroundSync Cleanup] Remove periodic sync code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@purge_power

Patch Set: Address comments from PS3 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_registration_options.cc ('k') | content/browser/background_sync/background_sync_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_service_impl.h

diff --git a/content/browser/background_sync/background_sync_service_impl.h b/content/browser/background_sync/background_sync_service_impl.h

index a5b6d184e06ecb54791856caa48885bf331aa30c..77df3b6a37935cbf94cbb3271b873719f2990b2f 100644

--- a/content/browser/background_sync/background_sync_service_impl.h

+++ b/content/browser/background_sync/background_sync_service_impl.h

@@ -39,15 +39,12 @@ class CONTENT_EXPORT BackgroundSyncServiceImpl

void Unregister(BackgroundSyncRegistrationHandle::HandleId handle_id,

int64_t sw_registration_id,

const UnregisterCallback& callback) override;

- void GetRegistration(BackgroundSyncPeriodicity periodicity,

- const mojo::String& tag,

+ void GetRegistration(const mojo::String& tag,

int64_t sw_registration_id,

const GetRegistrationCallback& callback) override;

- void GetRegistrations(BackgroundSyncPeriodicity periodicity,

- int64_t sw_registration_id,

+ void GetRegistrations(int64_t sw_registration_id,

const GetRegistrationsCallback& callback) override;

void GetPermissionStatus(

- BackgroundSyncPeriodicity periodicity,

int64_t sw_registration_id,

const GetPermissionStatusCallback& callback) override;

void DuplicateRegistrationHandle(