Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1584933002: Refactor to use GrWrapTextureInBitmap more (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update to ToT #

Patch Set 3 : Fix no-gpu build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -49 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkImageFilter.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrLayerHoister.cpp View 3 chunks +3 lines, -11 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 2 chunks +6 lines, -10 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
robertphillips
4 years, 11 months ago (2016-01-13 21:43:35 UTC) #4
bsalomon
lgtm
4 years, 11 months ago (2016-01-13 21:50:30 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584933002/1
4 years, 11 months ago (2016-01-13 21:54:00 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot/builds/703)
4 years, 11 months ago (2016-01-13 21:54:41 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584933002/20001
4 years, 11 months ago (2016-01-14 13:27:26 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/5256) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
4 years, 11 months ago (2016-01-14 13:28:17 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584933002/40001
4 years, 11 months ago (2016-01-14 13:50:39 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 14:01:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584933002/40001
4 years, 11 months ago (2016-01-14 14:02:35 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 14:03:33 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1de87df0b743e30619b8ba93ab0169fd41d0feae

Powered by Google App Engine
This is Rietveld 408576698