Beginning of support for texture rectangles.

Beginning of support for texture rectangles.

Adds support for importing a RECTANGLE texture into Skia via GrTexureProvider::wrapBackendTexture().

Tests read/writing pixels, copySurface, and clear.

Does not add support for texturing from a RECTANGLE texture as the coords will be incorrectly normalized.

BUG=skia:3868
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1583863002

Committed: https://skia.googlesource.com/skia/+/e5286e0b37abe4d0db67a6b3d87b2d5a12a70ab3

[bsalomon, 2016-01-13 16:42:32]

Description was changed from

==========
Beginning of support for texture rectangles

BUG=skia:3868
==========

to

==========
Beginning of support for texture rectangles

BUG=skia:3868
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-13 21:31:57]

Description was changed from

==========
Beginning of support for texture rectangles

BUG=skia:3868
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Beginning of support for texture rectangles.

Adds support for importing a RECTANGLE texture into Skia via
GrTexureProvider::wrapBackendTexture().

Tests read/writing pixels, copySurface, and clear.

Does not add support for texturing from a RECTANGLE texture as the coords will
be incorrectly normalized.

BUG=skia:3868
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-13 21:31:57]

bsalomon@google.com changed reviewers:
+ jvanverth@google.com

[bsalomon, 2016-01-14 16:38:54]

bsalomon@google.com changed reviewers:
+ ericrk@chromium.org

[bsalomon, 2016-01-14 16:38:54]

+Eric

[jvanverth1, 2016-01-14 16:47:21]

lgtm + comments

https://codereview.chromium.org/1583863002/diff/100001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1583863002/diff/100001/src/gpu/gl/GrGLGpu.cpp...
src/gpu/gl/GrGLGpu.cpp:615: // Write or transfer of pixels is no implemented for
TEXTURE_EXTERNAL textures
not implemented

https://codereview.chromium.org/1583863002/diff/100001/src/gpu/gl/GrGLProgram...
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/1583863002/diff/100001/src/gpu/gl/GrGLProgram...
src/gpu/gl/GrGLProgramDesc.cpp:19: static uint16_t texture_target_key(GrGLenum
target) {
Could you use TextureTargetToCopyProgramIdx as the key?

[bsalomon, 2016-01-14 17:11:50]

https://codereview.chromium.org/1583863002/diff/100001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1583863002/diff/100001/src/gpu/gl/GrGLGpu.cpp...
src/gpu/gl/GrGLGpu.cpp:615: // Write or transfer of pixels is no implemented for
TEXTURE_EXTERNAL textures
On 2016/01/14 16:47:21, jvanverth1 wrote:
> not implemented

Done.

https://codereview.chromium.org/1583863002/diff/100001/src/gpu/gl/GrGLProgram...
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/1583863002/diff/100001/src/gpu/gl/GrGLProgram...
src/gpu/gl/GrGLProgramDesc.cpp:19: static uint16_t texture_target_key(GrGLenum
target) {
On 2016/01/14 16:47:21, jvanverth1 wrote:
> Could you use TextureTargetToCopyProgramIdx as the key?

Actually I can just use the GLenum... they're all 16 bits. Did that (with
assertion).

[bsalomon, 2016-01-14 17:12:00]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-01-14 17:12:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1583863002/#ps120001
(title: "Address comments")

[commit-bot: I haz the power, 2016-01-14 17:12:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583863002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583863002/120001

[commit-bot: I haz the power, 2016-01-14 17:24:11]

Description was changed from

==========
Beginning of support for texture rectangles.

Adds support for importing a RECTANGLE texture into Skia via
GrTexureProvider::wrapBackendTexture().

Tests read/writing pixels, copySurface, and clear.

Does not add support for texturing from a RECTANGLE texture as the coords will
be incorrectly normalized.

BUG=skia:3868
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Beginning of support for texture rectangles.

Adds support for importing a RECTANGLE texture into Skia via
GrTexureProvider::wrapBackendTexture().

Tests read/writing pixels, copySurface, and clear.

Does not add support for texturing from a RECTANGLE texture as the coords will
be incorrectly normalized.

BUG=skia:3868
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/e5286e0b37abe4d0db67a6b3d87b2d5a12a70ab3
==========

[commit-bot: I haz the power, 2016-01-14 17:24:12]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/e5286e0b37abe4d0db67a6b3d87b2d5a12a70ab3