Texturing support for RECTANGLE textures.

Texturing support for RECTANGLE textures.

Uses textureSize() to unnormalize texture coords when reading from a RECTANGLE texture. Because of this we also require a later GLSL version to use rectangle textures (1.40).

Note that this causes a issue with the bicubic effect. The texture coords seem to have poor precision and the result is ugly. textureSize() is intended as a workaround until effects can be updated to handle unnormalized coords themselves.

Updates places where we were looking for OpenGL version 3.2 for rectangle support. It was actually added in 3.1.

BUG=skia:3868
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1594483003

Committed: https://skia.googlesource.com/skia/+/e179a9167f71dfc41668b05d40082aae76367fa6

[bsalomon, 2016-01-15 14:02:22]

Description was changed from

==========
WIP, texturing support for RECTANGLE textures.

BUG=skia:
==========

to

==========
WIP, texturing support for RECTANGLE textures.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-19 21:34:58]

Description was changed from

==========
WIP, texturing support for RECTANGLE textures.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Texturing support for RECTANGLE textures.

Uses textureSize() to unnormalize texture coords when reading from a RECTANGLE
texture. Because of this we also require a later GLSL version to use rectangle
textures (1.40).

Note that this causes a issue with the bicubic effect. The texture coords seem
to have poor precision and the result is ugly. textureSize() is intended as a
workaround until effects can be updated to handle unnormalized coords
themselves.

Updates places where we were looking for OpenGL version 3.2 for rectangle
support. It was actually added in 3.1.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-19 21:34:58]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-01-19 22:28:06]

lgtm with a few nits

https://codereview.chromium.org/1594483003/diff/150001/gm/rectangletexture.cpp
File gm/rectangletexture.cpp (right):

https://codereview.chromium.org/1594483003/diff/150001/gm/rectangletexture.cp...
gm/rectangletexture.cpp:70: if (!(kGL_GrGLStandard == glCtx->standard() &&
glCtx->version() >= GR_GL_VER(3, 1)) &&
care to check glsl version?

https://codereview.chromium.org/1594483003/diff/150001/gm/rectangletexture.cp...
gm/rectangletexture.cpp:107: desc.fConfig = kRGBA_8888_GrPixelConfig;
should this ever be BGRA?

https://codereview.chromium.org/1594483003/diff/150001/gm/rectangletexture.cp...
gm/rectangletexture.cpp:119: void deleteYUVTextures(GrContext* context, const
GrBackendObject yuvHandles[3]) {
function for other gm?

https://codereview.chromium.org/1594483003/diff/150001/src/gpu/GrTextureParam...
File src/gpu/GrTextureParamsAdjuster.cpp (right):

https://codereview.chromium.org/1594483003/diff/150001/src/gpu/GrTextureParam...
src/gpu/GrTextureParamsAdjuster.cpp:184: outOffset->set(0, 0);
if we find the key in the cache, we will now end up in this if (if outOffset is
true). This was not the case previously. Is this intended?

https://codereview.chromium.org/1594483003/diff/150001/src/gpu/GrTextureParam...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1594483003/diff/150001/src/gpu/GrTextureParam...
src/gpu/GrTextureParamsAdjuster.h:156: GrTexture *refCopy(const CopyParams
&copyParams);
put * on GrTexture

[bsalomon, 2016-01-19 22:37:52]

https://codereview.chromium.org/1594483003/diff/150001/gm/rectangletexture.cpp
File gm/rectangletexture.cpp (right):

https://codereview.chromium.org/1594483003/diff/150001/gm/rectangletexture.cp...
gm/rectangletexture.cpp:70: if (!(kGL_GrGLStandard == glCtx->standard() &&
glCtx->version() >= GR_GL_VER(3, 1)) &&
On 2016/01/19 22:28:06, egdaniel wrote:
> care to check glsl version?

If the GrContext doesn't support rectangle (b/c of GLSL version) then it will
just fail the wrap below and the result would be the same.

https://codereview.chromium.org/1594483003/diff/150001/gm/rectangletexture.cp...
gm/rectangletexture.cpp:107: desc.fConfig = kRGBA_8888_GrPixelConfig;
On 2016/01/19 22:28:05, egdaniel wrote:
> should this ever be BGRA?

Added comment that texture is always RGBA, but "pixels" may not be.

https://codereview.chromium.org/1594483003/diff/150001/gm/rectangletexture.cp...
gm/rectangletexture.cpp:119: void deleteYUVTextures(GrContext* context, const
GrBackendObject yuvHandles[3]) {
On 2016/01/19 22:28:05, egdaniel wrote:
> function for other gm?

Done.

https://codereview.chromium.org/1594483003/diff/150001/src/gpu/GrTextureParam...
File src/gpu/GrTextureParamsAdjuster.cpp (right):

https://codereview.chromium.org/1594483003/diff/150001/src/gpu/GrTextureParam...
src/gpu/GrTextureParamsAdjuster.cpp:184: outOffset->set(0, 0);
On 2016/01/19 22:28:06, egdaniel wrote:
> if we find the key in the cache, we will now end up in this if (if outOffset
is
> true). This was not the case previously. Is this intended?

Yes, it's a fix.

https://codereview.chromium.org/1594483003/diff/150001/src/gpu/GrTextureParam...
File src/gpu/GrTextureParamsAdjuster.h (right):

https://codereview.chromium.org/1594483003/diff/150001/src/gpu/GrTextureParam...
src/gpu/GrTextureParamsAdjuster.h:156: GrTexture *refCopy(const CopyParams
&copyParams);
On 2016/01/19 22:28:06, egdaniel wrote:
> put * on GrTexture

Done.

[bsalomon, 2016-01-19 22:38:29]

Description was changed from

==========
Texturing support for RECTANGLE textures.

Uses textureSize() to unnormalize texture coords when reading from a RECTANGLE
texture. Because of this we also require a later GLSL version to use rectangle
textures (1.40).

Note that this causes a issue with the bicubic effect. The texture coords seem
to have poor precision and the result is ugly. textureSize() is intended as a
workaround until effects can be updated to handle unnormalized coords
themselves.

Updates places where we were looking for OpenGL version 3.2 for rectangle
support. It was actually added in 3.1.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Texturing support for RECTANGLE textures.

Uses textureSize() to unnormalize texture coords when reading from a RECTANGLE
texture. Because of this we also require a later GLSL version to use rectangle
textures (1.40).

Note that this causes a issue with the bicubic effect. The texture coords seem
to have poor precision and the result is ugly. textureSize() is intended as a
workaround until effects can be updated to handle unnormalized coords
themselves.

Updates places where we were looking for OpenGL version 3.2 for rectangle
support. It was actually added in 3.1.

BUG=skia:3868

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-19 22:38:40]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-01-19 22:38:41]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1594483003/#ps170001
(title: "Address comments")

[commit-bot: I haz the power, 2016-01-19 22:38:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1594483003/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1594483003/170001

[commit-bot: I haz the power, 2016-01-19 22:40:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 22:40:44]

Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2016-01-19 22:46:09]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-01-19 22:46:10]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1594483003/#ps190001
(title: "fix double->float warnings on windows")

[commit-bot: I haz the power, 2016-01-19 22:46:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1594483003/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1594483003/190001

[commit-bot: I haz the power, 2016-01-19 22:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 22:48:15]

Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2016-01-20 14:07:17]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-01-20 14:07:17]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1594483003/#ps210001
(title: "fix float->int warnings")

[commit-bot: I haz the power, 2016-01-20 14:07:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1594483003/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1594483003/210001

[commit-bot: I haz the power, 2016-01-20 14:18:18]

Description was changed from

==========
Texturing support for RECTANGLE textures.

Uses textureSize() to unnormalize texture coords when reading from a RECTANGLE
texture. Because of this we also require a later GLSL version to use rectangle
textures (1.40).

Note that this causes a issue with the bicubic effect. The texture coords seem
to have poor precision and the result is ugly. textureSize() is intended as a
workaround until effects can be updated to handle unnormalized coords
themselves.

Updates places where we were looking for OpenGL version 3.2 for rectangle
support. It was actually added in 3.1.

BUG=skia:3868

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Texturing support for RECTANGLE textures.

Uses textureSize() to unnormalize texture coords when reading from a RECTANGLE
texture. Because of this we also require a later GLSL version to use rectangle
textures (1.40).

Note that this causes a issue with the bicubic effect. The texture coords seem
to have poor precision and the result is ugly. textureSize() is intended as a
workaround until effects can be updated to handle unnormalized coords
themselves.

Updates places where we were looking for OpenGL version 3.2 for rectangle
support. It was actually added in 3.1.

BUG=skia:3868

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/e179a9167f71dfc41668b05d40082aae76367fa6
==========

[commit-bot: I haz the power, 2016-01-20 14:18:19]

Committed patchset #12 (id:210001) as
https://skia.googlesource.com/skia/+/e179a9167f71dfc41668b05d40082aae76367fa6