Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 158133003: Move quota module to oilpan (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
CC:
blink-reviews, kinuko, oilpan-reviews, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move quota module to oilpan This moves the storage quota interfaces to oilpan, using transition types. Mostly regular, apart from one one interface (DeprecatedStorageQuota) being used from both a main world and worker context, requiring thread affinity defaults to be overridden for its class. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166819 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166849

Patch Set 1 #

Total comments: 8

Patch Set 2 : Remove conditional support for GCed-supplements #

Total comments: 24

Patch Set 3 : Revert having empty destructors in header files. #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -25 lines) Patch
M Source/modules/quota/DOMWindowQuota.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.h View 1 2 2 chunks +10 lines, -6 lines 5 comments Download
M Source/modules/quota/DeprecatedStorageInfo.cpp View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.h View 1 2 3 chunks +10 lines, -3 lines 3 comments Download
M Source/modules/quota/DeprecatedStorageQuota.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/NavigatorStorageQuota.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/quota/StorageInfo.h View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M Source/modules/quota/StorageInfo.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/quota/StorageInfo.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/StorageQuota.h View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M Source/modules/quota/StorageQuota.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/quota/StorageQuota.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/WorkerNavigatorStorageQuota.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 35 (0 generated)
sof
When you get the chance, please have a look. The #ifdef-ery used on the Supplement ...
6 years, 10 months ago (2014-02-09 20:29:25 UTC) #1
haraken
Thanks sof for the CL! I'm very excited that we have more contributors to oilpan. ...
6 years, 10 months ago (2014-02-10 01:34:57 UTC) #2
haraken
Nit note: Please add "oilpan-reviews@chromium.org" to oilpan CLs.
6 years, 10 months ago (2014-02-10 01:35:50 UTC) #3
kinuko
(+cc nhiroki)
6 years, 10 months ago (2014-02-10 04:59:51 UTC) #4
sof
Thanks haraken, I'll try to be useful to the effort. https://codereview.chromium.org/158133003/diff/1/Source/modules/quota/DOMWindowQuota.h File Source/modules/quota/DOMWindowQuota.h (right): https://codereview.chromium.org/158133003/diff/1/Source/modules/quota/DOMWindowQuota.h#newcode46 ...
6 years, 10 months ago (2014-02-10 07:35:12 UTC) #5
haraken
https://codereview.chromium.org/158133003/diff/1/Source/modules/quota/DOMWindowQuota.h File Source/modules/quota/DOMWindowQuota.h (right): https://codereview.chromium.org/158133003/diff/1/Source/modules/quota/DOMWindowQuota.h#newcode46 Source/modules/quota/DOMWindowQuota.h:46: #define RefPtrWillBePersistentThenMember RefPtrWillBePersistent On 2014/02/10 07:35:12, sof wrote: > ...
6 years, 10 months ago (2014-02-10 07:42:14 UTC) #6
sof
https://codereview.chromium.org/158133003/diff/1/Source/modules/quota/DeprecatedStorageInfo.h File Source/modules/quota/DeprecatedStorageInfo.h (right): https://codereview.chromium.org/158133003/diff/1/Source/modules/quota/DeprecatedStorageInfo.h#newcode48 Source/modules/quota/DeprecatedStorageInfo.h:48: class DeprecatedStorageInfo : public RefCountedWillBeGarbageCollectedFinalized<DeprecatedStorageInfo>, public ScriptWrappable { On ...
6 years, 10 months ago (2014-02-10 07:57:40 UTC) #7
haraken
LGTM kinuko, nhiroki: Would it be OK to land this oilpan change now? It will ...
6 years, 10 months ago (2014-02-10 08:15:22 UTC) #8
nhiroki
On 2014/02/10 08:15:22, haraken wrote: > kinuko, nhiroki: Would it be OK to land this ...
6 years, 10 months ago (2014-02-10 08:23:46 UTC) #9
sof
On 2014/02/10 08:23:46, nhiroki wrote: > On 2014/02/10 08:15:22, haraken wrote: > > kinuko, nhiroki: ...
6 years, 10 months ago (2014-02-10 08:26:26 UTC) #10
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-10 08:26:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/158133003/220001
6 years, 10 months ago (2014-02-10 08:26:39 UTC) #12
tkent
https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.cpp File Source/modules/quota/DOMWindowQuota.cpp (left): https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.cpp#oldcode56 Source/modules/quota/DOMWindowQuota.cpp:56: // static Ditto. https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.cpp#oldcode67 Source/modules/quota/DOMWindowQuota.cpp:67: // static Ditto. https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.h ...
6 years, 10 months ago (2014-02-10 08:27:40 UTC) #13
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-10 08:28:28 UTC) #14
sof
https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.h File Source/modules/quota/DOMWindowQuota.h (right): https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.h#newcode45 Source/modules/quota/DOMWindowQuota.h:45: virtual ~DOMWindowQuota() { } On 2014/02/10 08:27:40, tkent wrote: ...
6 years, 10 months ago (2014-02-10 08:32:13 UTC) #15
haraken
> Source/modules/quota/DOMWindowQuota.h:45: virtual ~DOMWindowQuota() { } > On 2014/02/10 08:27:40, tkent wrote: > > Why ...
6 years, 10 months ago (2014-02-10 08:37:40 UTC) #16
tkent
https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.h File Source/modules/quota/DOMWindowQuota.h (right): https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.h#newcode45 Source/modules/quota/DOMWindowQuota.h:45: virtual ~DOMWindowQuota() { } On 2014/02/10 08:32:13, sof wrote: ...
6 years, 10 months ago (2014-02-10 08:41:57 UTC) #17
sof
https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.h File Source/modules/quota/DOMWindowQuota.h (right): https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.h#newcode45 Source/modules/quota/DOMWindowQuota.h:45: virtual ~DOMWindowQuota() { } On 2014/02/10 08:41:57, tkent wrote: ...
6 years, 10 months ago (2014-02-10 08:45:09 UTC) #18
sof
https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.cpp File Source/modules/quota/DOMWindowQuota.cpp (left): https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.cpp#oldcode47 Source/modules/quota/DOMWindowQuota.cpp:47: DOMWindowQuota::~DOMWindowQuota() Reverted. https://codereview.chromium.org/158133003/diff/220001/Source/modules/quota/DOMWindowQuota.cpp#oldcode56 Source/modules/quota/DOMWindowQuota.cpp:56: // static On 2014/02/10 08:27:40, ...
6 years, 10 months ago (2014-02-10 09:07:19 UTC) #19
tkent
https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h File Source/modules/quota/DeprecatedStorageInfo.h (right): https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h#newcode36 Source/modules/quota/DeprecatedStorageInfo.h:36: #include "modules/quota/DeprecatedStorageQuota.h" This include looks unnecessary.
6 years, 10 months ago (2014-02-10 09:17:17 UTC) #20
sof
https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h File Source/modules/quota/DeprecatedStorageInfo.h (right): https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h#newcode36 Source/modules/quota/DeprecatedStorageInfo.h:36: #include "modules/quota/DeprecatedStorageQuota.h" On 2014/02/10 09:17:17, tkent wrote: > This ...
6 years, 10 months ago (2014-02-10 09:19:50 UTC) #21
haraken
https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h File Source/modules/quota/DeprecatedStorageInfo.h (right): https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h#newcode36 Source/modules/quota/DeprecatedStorageInfo.h:36: #include "modules/quota/DeprecatedStorageQuota.h" On 2014/02/10 09:19:51, sof wrote: > On ...
6 years, 10 months ago (2014-02-10 09:26:16 UTC) #22
tkent
lgtm. thank you! https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h File Source/modules/quota/DeprecatedStorageInfo.h (right): https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h#newcode36 Source/modules/quota/DeprecatedStorageInfo.h:36: #include "modules/quota/DeprecatedStorageQuota.h" On 2014/02/10 09:19:51, sof ...
6 years, 10 months ago (2014-02-10 09:28:38 UTC) #23
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 10 months ago (2014-02-10 09:28:53 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/158133003/430002
6 years, 10 months ago (2014-02-10 09:29:00 UTC) #25
commit-bot: I haz the power
Change committed as 166819
6 years, 10 months ago (2014-02-10 11:08:47 UTC) #26
dstockwell
A revert of this CL has been created in https://codereview.chromium.org/158873002/ by dstockwell@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-10 11:50:46 UTC) #27
sof
With https://codereview.chromium.org/148513008 having landed and the trybots showing green http://build.chromium.org/p/tryserver.chromium/builders/mac_blink_rel/builds/18144 http://build.chromium.org/p/tryserver.chromium/builders/linux_blink_rel/builds/21235 http://build.chromium.org/p/tryserver.chromium/builders/win_blink_rel/builds/26612 on top of ...
6 years, 10 months ago (2014-02-10 17:59:20 UTC) #28
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-10 17:59:30 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/158133003/430002
6 years, 10 months ago (2014-02-10 17:59:42 UTC) #30
commit-bot: I haz the power
Change committed as 166849
6 years, 10 months ago (2014-02-10 18:00:08 UTC) #31
Vyacheslav Egorov (Chromium)
DBC https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h File Source/modules/quota/DeprecatedStorageInfo.h (right): https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageInfo.h#newcode36 Source/modules/quota/DeprecatedStorageInfo.h:36: #include "modules/quota/DeprecatedStorageQuota.h" Member<X> should not need definition of ...
6 years, 10 months ago (2014-02-10 18:21:04 UTC) #32
sof
https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageQuota.h File Source/modules/quota/DeprecatedStorageQuota.h (right): https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageQuota.h#newcode73 Source/modules/quota/DeprecatedStorageQuota.h:73: USED_FROM_MULTIPLE_THREADS(DeprecatedStorageQuota); On 2014/02/10 18:21:05, Vyacheslav Egorov wrote: > On ...
6 years, 10 months ago (2014-02-11 06:54:54 UTC) #33
Vyacheslav Egorov (Chromium)
https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageQuota.h File Source/modules/quota/DeprecatedStorageQuota.h (right): https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/DeprecatedStorageQuota.h#newcode73 Source/modules/quota/DeprecatedStorageQuota.h:73: USED_FROM_MULTIPLE_THREADS(DeprecatedStorageQuota); On 2014/02/11 06:54:55, sof wrote: > On 2014/02/10 ...
6 years, 10 months ago (2014-02-11 11:19:59 UTC) #34
sof
6 years, 10 months ago (2014-02-11 15:10:54 UTC) #35
Message was sent while issue was closed.
On 2014/02/11 11:19:59, Vyacheslav Egorov wrote:
>
https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/De...
> File Source/modules/quota/DeprecatedStorageQuota.h (right):
> 
>
https://codereview.chromium.org/158133003/diff/430002/Source/modules/quota/De...
> Source/modules/quota/DeprecatedStorageQuota.h:73:
> USED_FROM_MULTIPLE_THREADS(DeprecatedStorageQuota);
> On 2014/02/11 06:54:55, sof wrote:
> > On 2014/02/10 18:21:05, Vyacheslav Egorov wrote:
> > > On the branch we were placing this into ThreadState.h to guarantee
> visibility
> > > and avoid including this file into all files that just use Persistent<> of
> > this
> > > type.
> > 
> > ah, ok.
> > 
> > I notice there's a FIXME just above that list in ThreadState.h ("find a
better
> > place for this.") There isn't?
> 
> Yeah, I think we did not succeed in finding one. 
> 
> We might want to have heap/ThreadAffinityTraits.h and put all of them there
and
> include it into heap/ThreadState.h. That's as good as it gets, I guess.

Thanks, yes. Having the do-i-need-custom-thread-affinity question on your
checklist when moving code over matters more.

Powered by Google App Engine
This is Rietveld 408576698