Move quota module to oilpan

Source/modules/quota/DOMWindowQuota.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef DOMWindowQuota_h
 #define DOMWindowQuota_h
 
 #include "core/frame/DOMWindowProperty.h"
+#include "heap/Handle.h"
 #include "platform/Supplementable.h"
 
 namespace WebCore {
 
 class DeprecatedStorageInfo;
 class DOMWindow;
 
+#ifdef DOMWindow_IS_GARBAGE_COLLECTED
+#define RefPtrWillBePersistentThenMember RefPtrWillBeMember
+#else
+#define RefPtrWillBePersistentThenMember RefPtrWillBePersistent

[haraken, 2014/02/10 01:34:58]

I understand your intention, but I'm not really happy with introducing more
oilpan types and #if macros. Given that it will take a long time to move
DOMWindow and Navigator to oilpan, we will end up having the confusing types and
macros for a long time in the code base.

I'd prefer just using RefPtrWillBePersistent at the moment. Once we move
DOMWindow to oilpan, we can just change it to RefPtrWillBeMember.

The oilpan system already has an ASSERT to verify that Persistent is not used in
on-heap objects. So if we forget to replace RefPtrWillBePersistent with
RefPtrMember, we will be asserted. Thus I think it's OK to use
RefPtrWillBePersistent at the moment.

[sof, 2014/02/10 07:35:12]

...
That works for me; main concern was that we'd accidentally forget about going
over the code again once these Supplementables become GCed. I've removed the
#ifdefs.

[haraken, 2014/02/10 07:42:14]

Yeah, that's a valid concern. Fortunately, if we forget to change Persistent to
Member, we will be asserted, so we don't need to worry about it :)

+#endif
+
 class DOMWindowQuota FINAL : public Supplement<DOMWindow>, public DOMWindowProperty {
+#ifdef DOMWindow_IS_GARBAGE_COLLECTED
+    DECLARE_GC_INFO;
+#endif
 public:
-    virtual ~DOMWindowQuota();
+    virtual ~DOMWindowQuota() { }
     static DOMWindowQuota* from(DOMWindow*);
     static DeprecatedStorageInfo* webkitStorageInfo(DOMWindow*);
     DeprecatedStorageInfo* webkitStorageInfo() const;
 
+#ifdef DOMWindow_IS_GARBAGE_COLLECTED
+    void trace(Visitor*);
+#endif
+
 private:
     explicit DOMWindowQuota(DOMWindow*);
     static const char* supplementName();
 
-    mutable RefPtr<DeprecatedStorageInfo> m_storageInfo;
+    mutable RefPtrWillBePersistentThenMember<DeprecatedStorageInfo> m_storageInfo;
 };
 
+#undef RefPtrWillBePersistentThenMember
+
 } // namespace WebCore
 
 #endif // DOMWindowQuota_h