Chromium Code Reviews| Index: Source/modules/quota/DeprecatedStorageInfo.h |
| diff --git a/Source/modules/quota/DeprecatedStorageInfo.h b/Source/modules/quota/DeprecatedStorageInfo.h |
| index 57e6c22a1f67b6e530f1d7e301aafd3b61f49b45..472e27e57523564a92e08d4db14e6f655bdc2e49 100644 |
| --- a/Source/modules/quota/DeprecatedStorageInfo.h |
| +++ b/Source/modules/quota/DeprecatedStorageInfo.h |
| @@ -32,28 +32,30 @@ |
| #define DeprecatedStorageInfo_h |
| #include "bindings/v8/ScriptWrappable.h" |
| +#include "heap/Handle.h" |
| +#include "modules/quota/DeprecatedStorageQuota.h" |
|
tkent
2014/02/10 09:17:17
This include looks unnecessary.
sof
2014/02/10 09:19:51
But it isn't. You need the explicit #include to ge
haraken
2014/02/10 09:26:17
Yeah, if we use Member<X>/Persistent<X>, we need t
tkent
2014/02/10 09:28:39
ok, I undetstand.
Vyacheslav Egorov (Chromium)
2014/02/10 18:21:05
Member<X> should not need definition of X as it is
|
| #include "wtf/PassRefPtr.h" |
| #include "wtf/RefCounted.h" |
| #include "wtf/RefPtr.h" |
| namespace WebCore { |
| -class DeprecatedStorageQuota; |
| class ExecutionContext; |
| class StorageErrorCallback; |
| class StorageQuotaCallback; |
| class StorageUsageCallback; |
| -class DeprecatedStorageInfo : public RefCounted<DeprecatedStorageInfo>, public ScriptWrappable { |
| +class DeprecatedStorageInfo : public RefCountedWillBeGarbageCollectedFinalized<DeprecatedStorageInfo>, public ScriptWrappable { |
| + DECLARE_GC_INFO; |
| public: |
| enum { |
| TEMPORARY, |
| PERSISTENT, |
| }; |
| - static PassRefPtr<DeprecatedStorageInfo> create() |
| + static PassRefPtrWillBeRawPtr<DeprecatedStorageInfo> create() |
| { |
| - return adoptRef(new DeprecatedStorageInfo()); |
| + return adoptRefWillBeNoop(new DeprecatedStorageInfo()); |
| } |
| void queryUsageAndQuota(ExecutionContext*, int storageType, PassOwnPtr<StorageUsageCallback>, PassOwnPtr<StorageErrorCallback>); |
| @@ -62,13 +64,15 @@ public: |
| ~DeprecatedStorageInfo(); |
| + void trace(Visitor*); |
| + |
| private: |
| DeprecatedStorageInfo(); |
| DeprecatedStorageQuota* getStorageQuota(int storageType); |
| - mutable RefPtr<DeprecatedStorageQuota> m_temporaryStorage; |
| - mutable RefPtr<DeprecatedStorageQuota> m_persistentStorage; |
| + mutable RefPtrWillBeMember<DeprecatedStorageQuota> m_temporaryStorage; |
| + mutable RefPtrWillBeMember<DeprecatedStorageQuota> m_persistentStorage; |
| }; |
| } // namespace WebCore |