Move quota module to oilpan

Source/modules/quota/DeprecatedStorageInfo.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef DeprecatedStorageInfo_h
 #define DeprecatedStorageInfo_h
 
 #include "bindings/v8/ScriptWrappable.h"
+#include "heap/Handle.h"
+#include "modules/quota/DeprecatedStorageQuota.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
 
-class DeprecatedStorageQuota;
 class ExecutionContext;
 class StorageErrorCallback;
 class StorageQuotaCallback;
 class StorageUsageCallback;
 
-class DeprecatedStorageInfo : public RefCounted<DeprecatedStorageInfo>, public ScriptWrappable {
+class DeprecatedStorageInfo : public RefCountedWillBeGarbageCollectedFinalized<DeprecatedStorageInfo>, public ScriptWrappable {

[haraken, 2014/02/10 01:34:58]

Isn't USED_FROM_MULTIPLE_THREADS(DeprecatedStorageInfo) needed? I'm not sure.

(This week we'll work on removing USED_FROM_MULTIPLE_THREADS macros completely,
since if we forget to add the macro, it will cause a bunch of threading troubles
in tests and real world.)

[sof, 2014/02/10 07:35:12]

It shouldn't be needed, as there are no DeprecatedStorageInfo persistents on
WorkerNavigatorStorageQuota.

Will keep an eye on the changes made in this area; it's quite brittle as it is.

[haraken, 2014/02/10 07:42:14]

Thanks, but would you add USED_FROM_MULTIPLE_THREADS if DeprecatedStorageInfo
can be potentially used by non-main threads? Otherwise, it will start crashing
once we start using Member<DeprecatedStorageInfo> or
Persistent<DeprecatedStorageInfo> somewhere.

(This rule is fragile and that's why I want to remove USED_FROM_MULTIPLE_THREADS
:-)

[sof, 2014/02/10 07:57:41]

I would clearly add it if that's a possibility, but I don't see how it can
happen overnight here (StorageInfos are only on "window"). Do we want to
future-proof many/most objects this way? i.e., I want to understand what the
rule is first :)

[haraken, 2014/02/10 08:15:23]

I'm sorry, if it's on window, it shouldn't be touched by workers. Sorry, let's
get rid of the macro.

In my understanding, a reasonable rule would be "if the object can be touched by
workers, we should add the macro".

+    DECLARE_GC_INFO;
 public:
     enum {
         TEMPORARY,
         PERSISTENT,
     };
 
-    static PassRefPtr<DeprecatedStorageInfo> create()
+    static PassRefPtrWillBeRawPtr<DeprecatedStorageInfo> create()
     {
-        return adoptRef(new DeprecatedStorageInfo());
+        return adoptRefWillBeNoop(new DeprecatedStorageInfo());
     }
 
     void queryUsageAndQuota(ExecutionContext*, int storageType, PassOwnPtr<StorageUsageCallback>, PassOwnPtr<StorageErrorCallback>);
 
     void requestQuota(ExecutionContext*, int storageType, unsigned long long newQuotaInBytes, PassOwnPtr<StorageQuotaCallback>, PassOwnPtr<StorageErrorCallback>);
 
-    ~DeprecatedStorageInfo();
+    ~DeprecatedStorageInfo() { }
+
+    void trace(Visitor*);
 
 private:
     DeprecatedStorageInfo();
 
     DeprecatedStorageQuota* getStorageQuota(int storageType);
 
-    mutable RefPtr<DeprecatedStorageQuota> m_temporaryStorage;
-    mutable RefPtr<DeprecatedStorageQuota> m_persistentStorage;
+    mutable RefPtrWillBeMember<DeprecatedStorageQuota> m_temporaryStorage;
+    mutable RefPtrWillBeMember<DeprecatedStorageQuota> m_persistentStorage;
 };
 
 } // namespace WebCore
 
 #endif // DeprecatedStorageInfo_h