Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2593)

Unified Diff: Source/modules/quota/DeprecatedStorageQuota.h

Issue 158133003: Move quota module to oilpan (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Revert having empty destructors in header files. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/quota/DeprecatedStorageQuota.h
diff --git a/Source/modules/quota/DeprecatedStorageQuota.h b/Source/modules/quota/DeprecatedStorageQuota.h
index 793644c3096ce7dcfb5382da6b00df7035d8df2e..f48a863b14987602c4337b66e6d48bb7ee141d41 100644
--- a/Source/modules/quota/DeprecatedStorageQuota.h
+++ b/Source/modules/quota/DeprecatedStorageQuota.h
@@ -32,6 +32,8 @@
#define DeprecatedStorageQuota_h
#include "bindings/v8/ScriptWrappable.h"
+#include "heap/Handle.h"
+#include "heap/ThreadState.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
@@ -42,16 +44,17 @@ class StorageErrorCallback;
class StorageQuotaCallback;
class StorageUsageCallback;
-class DeprecatedStorageQuota : public RefCounted<DeprecatedStorageQuota>, public ScriptWrappable {
+class DeprecatedStorageQuota : public RefCountedWillBeGarbageCollectedFinalized<DeprecatedStorageQuota>, public ScriptWrappable {
+ DECLARE_GC_INFO;
public:
enum Type {
Temporary,
Persistent,
};
- static PassRefPtr<DeprecatedStorageQuota> create(Type type)
+ static PassRefPtrWillBeRawPtr<DeprecatedStorageQuota> create(Type type)
{
- return adoptRef(new DeprecatedStorageQuota(type));
+ return adoptRefWillBeNoop(new DeprecatedStorageQuota(type));
}
void queryUsageAndQuota(ExecutionContext*, PassOwnPtr<StorageUsageCallback>, PassOwnPtr<StorageErrorCallback>);
@@ -60,11 +63,15 @@ public:
~DeprecatedStorageQuota();
+ void trace(Visitor*) { }
+
private:
explicit DeprecatedStorageQuota(Type);
Type m_type;
};
+USED_FROM_MULTIPLE_THREADS(DeprecatedStorageQuota);
Vyacheslav Egorov (Chromium) 2014/02/10 18:21:05 On the branch we were placing this into ThreadStat
sof 2014/02/11 06:54:55 ah, ok. I notice there's a FIXME just above that
Vyacheslav Egorov (Chromium) 2014/02/11 11:20:00 Yeah, I think we did not succeed in finding one.
+
} // namespace WebCore
#endif // DeprecatedStorageQuota_h

Powered by Google App Engine
This is Rietveld 408576698