Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Issue 148513008: Add ScriptPromiseResolver RawPtr overloads. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add ScriptPromiseResolver RawPtr overloads. In an Oilpan setting, promises may now be passed RawPtr<> values instead of RefPtr<>s. Accommodate such use by adding the needed reject() + resolve() overloads. (This change has been extricated from https://codereview.chromium.org/153083006 which we're holding off on in its entirety for the time being.) R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/bindings/v8/ScriptPromiseResolver.h View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look. Needed by https://codereview.chromium.org/158133003/
6 years, 10 months ago (2014-02-10 14:49:00 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-02-10 14:56:57 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-10 14:57:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/148513008/1
6 years, 10 months ago (2014-02-10 14:57:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 16:20:39 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-02-10 16:20:39 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-10 16:21:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/148513008/1
6 years, 10 months ago (2014-02-10 16:21:08 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 16:21:20 UTC) #9
Message was sent while issue was closed.
Change committed as 166840

Powered by Google App Engine
This is Rietveld 408576698