Move quota module to oilpan

Source/modules/quota/DeprecatedStorageInfo.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef DeprecatedStorageInfo_h
 #define DeprecatedStorageInfo_h
 
 #include "bindings/v8/ScriptWrappable.h"
+#include "heap/Handle.h"
+#include "modules/quota/DeprecatedStorageQuota.h"

[tkent, 2014/02/10 09:17:17]

This include looks unnecessary.

[sof, 2014/02/10 09:19:51]

But it isn't. You need the explicit #include to get the correct ThreadingTrait<>
instantiation. Without it, you'll run into redefinitions.

[haraken, 2014/02/10 09:26:17]

Yeah, if we use Member<X>/Persistent<X>, we need to include X.h into the header
file... (This has caused #include cycles in our experimental branch. We need to
address the cycle case-by-case.)

[tkent, 2014/02/10 09:28:39]

ok, I undetstand.

[Vyacheslav Egorov (Chromium), 2014/02/10 18:21:05]

Member<X> should not need definition of X as it is just a raw pointer
essentially. I am not sure I follow why this was included here.

On 2014/02/10 09:28:39, tkent wrote:

 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
 
-class DeprecatedStorageQuota;
 class ExecutionContext;
 class StorageErrorCallback;
 class StorageQuotaCallback;
 class StorageUsageCallback;
 
-class DeprecatedStorageInfo : public RefCounted<DeprecatedStorageInfo>, public ScriptWrappable {
+class DeprecatedStorageInfo : public RefCountedWillBeGarbageCollectedFinalized<DeprecatedStorageInfo>, public ScriptWrappable {
+    DECLARE_GC_INFO;
 public:
     enum {
         TEMPORARY,
         PERSISTENT,
     };
 
-    static PassRefPtr<DeprecatedStorageInfo> create()
+    static PassRefPtrWillBeRawPtr<DeprecatedStorageInfo> create()
     {
-        return adoptRef(new DeprecatedStorageInfo());
+        return adoptRefWillBeNoop(new DeprecatedStorageInfo());
     }
 
     void queryUsageAndQuota(ExecutionContext*, int storageType, PassOwnPtr<StorageUsageCallback>, PassOwnPtr<StorageErrorCallback>);
 
     void requestQuota(ExecutionContext*, int storageType, unsigned long long newQuotaInBytes, PassOwnPtr<StorageQuotaCallback>, PassOwnPtr<StorageErrorCallback>);
 
     ~DeprecatedStorageInfo();
 
+    void trace(Visitor*);
+
 private:
     DeprecatedStorageInfo();
 
     DeprecatedStorageQuota* getStorageQuota(int storageType);
 
-    mutable RefPtr<DeprecatedStorageQuota> m_temporaryStorage;
-    mutable RefPtr<DeprecatedStorageQuota> m_persistentStorage;
+    mutable RefPtrWillBeMember<DeprecatedStorageQuota> m_temporaryStorage;
+    mutable RefPtrWillBeMember<DeprecatedStorageQuota> m_persistentStorage;
 };
 
 } // namespace WebCore
 
 #endif // DeprecatedStorageInfo_h