Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1579863003: Convert Pass()→std::move() for Mac build. (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
dcheng, aboxhall+watch_chromium.org, asanka, avayvod+watch_chromium.org, bondd+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gcasto+watchlist_chromium.org, groby+spellwatch_chromium.org, grt+watch_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jbauman+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, je_julie, kalyank, kinuko+fileapi, mcasas+watch_chromium.org, Matt Giuca, miu+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-sensors_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-notifications_chromium.org, Michael van Ouwerkerk, nektar+watch_chromium.org, nhiroki, nona+watch_chromium.org, Peter Beverloo, piman+watch_chromium.org, plundblad+watch_chromium.org, posciak+watch_chromium.org, rickyz+watch_chromium.org, riju_, rlp+watch_chromium.org, rouslan+autofill_chromium.org, rouslan+spell_chromium.org, scheib+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, stevenjb+watch_chromium.org, James Su, tapted, tdanderson+views_chromium.org, tfarina, Lei Zhang, timvolodine, tommycli, tzik, vabr+watchlistautofill_chromium.org, vabr+watchlistpasswordmanager_chromium.org, xjz+watch_chromium.org, yusukes+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() for Mac build. BUG=557422 R=avi@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/f26eed3771b06cb2bf02e5d02e6f19a20f97a00b Cr-Commit-Position: refs/heads/master@{#369135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -299 lines) Patch
M chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_file_util.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_file_util_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_file_util.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc View 3 chunks +22 lines, -20 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac_unittest.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/simple_password_store_mac.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/plugins/plugin_installer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_installer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/policy/chrome_browser_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/sandboxed_dmg_analyzer_mac.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/layout_view.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm View 10 chunks +28 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/save_password_infobar_controller.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_avatar_fetcher_manager.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm View 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/browser_dialogs_views_mac.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/media_galleries/picasa_album_table_reader.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/utility/media_galleries/picasa_album_table_reader_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/utility/safe_browsing/mac/dmg_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/safe_browsing/mac/udif.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/policy/core/common/mac_util.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/policy/core/common/policy_loader_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_mac_unittest.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M components/wifi/network_properties.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/wifi_test.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_mac.mm View 5 chunks +7 lines, -8 lines 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/browser_compositor_view_mac.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/device_sensors/ambient_light_mac.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 2 chunks +7 lines, -8 lines 0 comments Download
M content/common/font_list_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_main.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_l2cap_channel_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_rfcomm_channel_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_socket_mac.mm View 4 chunks +4 lines, -3 lines 0 comments Download
M device/serial/serial_device_enumerator_mac.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M media/capture/video/mac/video_capture_device_decklink_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download
M media/capture/video/mac/video_capture_device_factory_mac.mm View 5 chunks +6 lines, -4 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M sandbox/mac/bootstrap_sandbox.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/message_center/cocoa/popup_collection_unittest.mm View 12 chunks +14 lines, -12 lines 0 comments Download
M ui/views/widget/native_widget_mac.mm View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
dcheng
More of the usual. avi@ for overall review/sanity check TBR jam@ for owners stamp
4 years, 11 months ago (2016-01-13 02:09:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579863003/1
4 years, 11 months ago (2016-01-13 02:10:27 UTC) #6
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2016-01-13 02:56:51 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-13 03:37:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579863003/1
4 years, 11 months ago (2016-01-13 10:25:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 10:58:22 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 10:59:48 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f26eed3771b06cb2bf02e5d02e6f19a20f97a00b
Cr-Commit-Position: refs/heads/master@{#369135}

Powered by Google App Engine
This is Rietveld 408576698