chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm - Issue 1579863003: Convert Pass()→std::move() for Mac build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

Issue 1579863003: Convert Pass()→std::move() for Mac build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

index 2e069dd42d362bb6f51e7594aea724dc2697cbb5..d9068be2e74ef5bbd640b94a2f1ef2a16c1ce28a 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

@@ -4,6 +4,8 @@

#import "chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h"

+#include <utility>

#include "chrome/browser/extensions/extension_install_prompt_show_params.h"

#include "chrome/browser/extensions/extension_install_prompt_test_helper.h"

#include "chrome/browser/ui/browser.h"

@@ -37,9 +39,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest, BasicTest) {

chrome::BuildExtensionInstallPrompt(extension_.get());

ExtensionInstallDialogController* controller =

- new ExtensionInstallDialogController(&show_params,

- test_helper.GetCallback(),

- prompt.Pass());

+ new ExtensionInstallDialogController(

+ &show_params, test_helper.GetCallback(), std::move(prompt));

base::scoped_nsobject<NSWindow> window(

[[[controller->view_controller() view] window] retain]);

@@ -65,9 +66,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest,

chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get());