chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm - Issue 1579863003: Convert Pass()→std::move() for Mac build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

Issue 1579863003: Convert Pass()→std::move() for Mac build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

index f043fad5a0c019634695a187d725aec839d59d58..16f755c1971d44e92bfc34f6131b0128f3a3b67f 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"

+#include <utility>

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h"

@@ -29,7 +31,8 @@ ConstrainedWindowMac::ConstrainedWindowMac(

auto manager = WebContentsModalDialogManager::FromWebContents(web_contents);

scoped_ptr<SingleWebContentsDialogManagerCocoa> native_manager(

new SingleWebContentsDialogManagerCocoa(this, sheet, manager));

- manager->ShowDialogWithManager([sheet sheetWindow], native_manager.Pass());

+ manager->ShowDialogWithManager([sheet sheetWindow],

+ std::move(native_manager));

}

ConstrainedWindowMac::~ConstrainedWindowMac() {