chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm - Issue 1579863003: Convert Pass()→std::move() for Mac build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm

Issue 1579863003: Convert Pass()→std::move() for Mac build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm ('k') | chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm

diff --git a/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm b/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm

index 81a66487deb31e8954c9f1ded78b7eeffef26565..983ae5277981a11df6b259b985356e3249b5d51b 100644

--- a/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm

+++ b/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm

@@ -4,6 +4,8 @@

#import "chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h"

+#include <utility>

#include "base/profiler/scoped_tracker.h"

#import "chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.h"

#include "chrome/browser/ui/browser.h"

@@ -61,7 +63,7 @@ void ChromeWebContentsViewDelegateMac::ShowMenu(

FROM_HERE_WITH_EXPLICIT_FUNCTION(

"458401 ChromeWebContentsViewDelegateMac::ShowMenu"));

- context_menu_ = menu.Pass();

+ context_menu_ = std::move(menu);

if (!context_menu_.get())

return;

@@ -113,7 +115,7 @@ ChromeWebContentsViewDelegateMac::BuildMenu(

menu->Init();

}

- return menu.Pass();

+ return menu;

}

content::RenderWidgetHostView*