chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm - Issue 1579863003: Convert Pass()→std::move() for Mac build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm

Issue 1579863003: Convert Pass()→std::move() for Mac build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm

index 8da3f175bb5c3d07098bcbf50257c6a14e9f8c0c..db8a936d128f3f59c343b51fdb6f80c0d80a5ca2 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm

@@ -73,7 +73,7 @@ void ExtensionActionPlatformDelegateCocoa::ShowPopup(

ExtensionActionViewController::PopupShowAction show_action) {

BOOL devMode =

show_action == ExtensionActionViewController::SHOW_POPUP_AND_INSPECT;

- [ExtensionPopupController host:host.Pass()

+ [ExtensionPopupController host:std::move(host)

inBrowser:controller_->browser()

anchoredAt:GetPopupPoint()

arrowLocation:info_bubble::kTopRight